Mark some projects as non-packable or non-shippable #25468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Pilchie this changes what we ship. So I'm asking for your approval. Please… |
wtgodbe
reviewed
Aug 31, 2020
wtgodbe
approved these changes
Aug 31, 2020
Member
wtgodbe
left a comment
wtgodbe
left a comment
There was a problem hiding this comment.
Looks good pending the 1 question
dougbu
commented
Aug 31, 2020
src/Components/WebAssembly/Sdk/src/Microsoft.NET.Sdk.BlazorWebAssembly.csproj
Outdated
Show resolved
Hide resolved
dougbu
commented
Aug 31, 2020
src/Components/WebAssembly/Sdk/src/Microsoft.NET.Sdk.BlazorWebAssembly.csproj
Outdated
Show resolved
Hide resolved
Member
|
Seems good to me. Approved for RC1 pending CI |
pranavkm
approved these changes
Aug 31, 2020
- used `$(IsUnitTestProject)` in src/Razor/test; slightly more correct
- don't seem to have any actual tests in this folder (unless I missed something)
dougbu
force-pushed
the
dougbu/non-shipping.non-packable
branch
from
2746b63 to
6e70b9e
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
allisonchou
added
[temp] unlock razor tooling issues
and removed
[obsolete] area-razor.tooling
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(IsUnitTestProject)in src/Razor/test; slightly more correct