Duplicate DBContextOptions registered in DI

[JunTaoLuo]

While debugging a failure in our blazorwasm templates with individual auth using local databases, I encountered an issue that broke DatabaseDeveloperPageExceptionFilter. Specifically it seems like two instances of DBContextOptions<ApplicationDBContext> were registered in DI. This eventually caused an issue where FinalizeModel was called twice and it threw on the second call. While we can workaround the issue by deduping the context options in the exception filter, it seems like a bug that two context options were registered in the first place.

I'm assigning @smitpatel since he helped me debug this issue and has some context so he can help fill in the blanks in case I missed some details.

Steps to reproduce

Repro: https://github.com/JunTaoLuo/DuplicateContext
Run the project and set a breakpoint in DatabaseDeveloperPageExceptionFilter to observe the duplicated dbcontexts.

Further technical details

EF Core version: 5.0.0-rc.1.20430.4
Database provider: e.g. Microsoft.EntityFrameworkCore.SqlServer
Target framework: net5.0
Operating system:
IDE:

[JeremyLikness]

@smitpatel please check 3.1 for regression.

[ajcvickers]

@JunTaoLuo I am not able to reproduce this. I do see the same DbContextOptions registered twice, but once as a the generic type and once as the non-generic type:

This is expected. I also verified that errorContext.HttpContext.RequestServices.GetServices<DbContextOptions>() only returns the non-generic registration, which is again as expected. I have not been able to get int a state where errorContext.HttpContext.RequestServices.GetServices<DbContextOptions>() returns more than one, except when more than one context type is registered, where it is again expected.

[ajcvickers]

@JunTaoLuo Ping

[JunTaoLuo]

Hmm I'll need to see why the repro isn't working for you then. Since I definitely ran into the described issue, which is why we have the code https://github.com/dotnet/aspnetcore/blob/master/src/Middleware/Diagnostics.EntityFrameworkCore/src/DatabaseDeveloperPageExceptionFilter.cs#L56-L58. I'll update this issue if I have more details.