This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 407
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
v0.25.0-0 QA Review #1936
Copy link
Copy link
Closed
Labels
qualityQuality assurance pass checklist for a prerelease versionQuality assurance pass checklist for a prerelease version
Description
Included PRs:
- Fetch and display readonly inline comments. #1856: Fetch and display readonly inline comments
Most testing done with https://github.com/kuychaco/test-repo/pull/5/files- PRs with a large # of reviews and comments should load in a reasonable amount of time (tested first 6 PRs in each of the two lists (12 total) contained here https://github.com/github/analytics/pull/454#issuecomment-382155693)
-
⚠️ ensure that comment thread order is retained when viewing a pull request that has paginated comments and reviews (that is, if there are multiple comment threads, the threads show up in the right order) (see Comment threads on same line appear in the wrong order #1944) - ensure that comment order within a thread is retained when viewing a pull request that has paginated comments and reviews
- ensure that comments are positioned on the same line of the diff as they are on github dotcom
- single comments (that are NOT part of a review) should show up
-
⚠️ resolved comments should not show up (see Update babel-plugin-relay to the latest version 🚀 #1973) - outdated comments should not show up
-
⚠️ replies to resolved comments should not show up (see Resolved comment showing up in Files Changed tab #1937) - hidden comments and their replies to show up correctly (as they do on dotcom)
- replies to outdated comments should not show up
- replies to deleted stand-alone comments should not show up (like on dotcom)
- replies to deleted comments in reviews show up (like on dotcom)
- make commit message template ignore commented lines #1902: make commit message template ignore commented lines
- Find and replace integration #1922: Find and replace integration
- add committer name to commit detail pane #1906: add committer name to commit detail pane
- Visual tweaks to Github's Remote Selector & No Remote views #1927: Visual tweaks to Github's Remote Selector & No Remote views
PRs without verification steps:
- Correct remaining flapping test coverage #1903: Correct remaining flapping test coverage
- Test coverage for GitShellOutStrategy #1900: Test coverage for GitShellOutStrategy
- Test coverage for GitTempDir #1901: Test coverage for GitTempDir
- Upgrade Globby #1896: Upgrade Globby
- Upgrade dugite #1893: Upgrade dugite
- Update moment #1894: Upgrade moment
- Update all of our dev dependencies in one fell swoop #1891: Update all of our dev dependencies in one fell swoop
- Upgrade to the latest react and react-dom #1884: Upgrade to the latest react and react-dom
- Synchronize electron-link and electron-mksnapshot versions to Atom's #1885: Synchronize electron-link and electron-mksnapshot versions to Atom's
- clean CI check on Update github package to v0.25.0-0 pre-release atom#18787
Metadata
Metadata
Assignees
Labels
qualityQuality assurance pass checklist for a prerelease versionQuality assurance pass checklist for a prerelease version