add committer name to commit detail pane

[annthurium]

Description of the Change

This change adds the committer's full name to the commit detail pane. Instead of email address, we show the full name.

Alternate Designs

• I considered showing the name and email address. However, it looked kinda cluttered, and I couldn't find a good way of showing co author info in that scenario.

Benefits

• Makes it easier to understand at a glance who made the commit
• Feature has been requested by folks in the community

Possible Drawbacks

• If folks need the email address of a committer for some reason, now it would take more effort to find it.

Applicable Issues

#1875

Metrics

N/A

Tests

• Manually tested that committer name shows up as expected for single commits
• Commiter name shows up as expected for co authored commits
• name falls back to something reasonable (such as email address or GitHub username) if committer name is not set in git config
• all new lines covered by unit tests

Documentation

N/A

Release Notes

TBD

User Experience Research (Optional)

N/A

[codecov]

Codecov Report

Merging #1906 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
+ Coverage    92.1%   92.11%   +0.01%     
==========================================
  Files         189      189              
  Lines       10779    10783       +4     
  Branches     1580     1580              
==========================================
+ Hits         9928     9933       +5     
+ Misses        851      850       -1

Impacted Files	Coverage Δ
lib/models/commit.js	92.23% <100%> (+0.31%)	⬆️
lib/views/commit-detail-view.js	100% <100%> (ø)	⬆️
lib/git-shell-out-strategy.js	100% <100%> (ø)	⬆️
lib/atom/gutter.js	92.3% <0%> (+2.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f360e...825e36e. Read the comment docs.

[annthurium]

hey @simurai -- this isn't urgent, but if you feel like making this look better, that'd be cool.

Right now it's like:

[annthurium]

Note for future Tilde or whomever ends up picking this up...

I tried testing the case where the commiter name does not exist by unsetting my email, username, and github handle in my git config. Git won't let you commit without one of those things set.

If I unset my github user alias, somehow name is falling back to annthurium. So weird! I don't think it's being pulled from my email address either, because I tried modifying that. Needs further investigation.

[smashwilson]

From now on, all of my commit messages will be "hunks hunks hunks"

[simurai]

How about replacing the current email with the author name and not have both?

And only use the email as a fallback if name or username doesn't exist?

Then the case of multiple authors should also be covered. E.g. [name] and 3 others committed....

[annthurium]

@simurai I like that! I'll move this in that direction.