Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

@smashwilson smashwilson commented Jan 4, 2019

To ensure that the snapshot test is as accurate as possible, lock electron-link and electron-mksnapshot to the version ranges specified in atom/atom's package.json.

Closes #1861; closes #1834.

@smashwilson smashwilson changed the title Upgrade electron-link to 0.3.2 Synchronize electron-link and electron-mksnapshot versions to Atom's Jan 4, 2019
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #1885 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1885      +/-   ##
==========================================
- Coverage   91.19%   91.14%   -0.05%     
==========================================
  Files         196      196              
  Lines       10745    10745              
  Branches     1574     1575       +1     
==========================================
- Hits         9799     9794       -5     
- Misses        946      951       +5
Impacted Files Coverage Δ
lib/models/github-login-model.js 78.33% <0%> (-11.5%) ⬇️
lib/shared/keytar-strategy.js 57.81% <0%> (-0.33%) ⬇️
lib/models/repository-states/present.js 95.02% <0%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10fb086...fd590c2. Read the comment docs.

@smashwilson smashwilson requested a review from a team January 4, 2019 20:23
Copy link

@annthurium annthurium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@smashwilson smashwilson merged commit 391514c into master Jan 4, 2019
@smashwilson smashwilson deleted the greenkeeper/electron-link-0.3.2 branch January 4, 2019 20:49
@kuychaco kuychaco mentioned this pull request Feb 4, 2019
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants