Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

Now that atom/electron-link#15 is out, we should be able to update to the latest React builds without hitting weird snapshotting errors or silently falling back to ancient browser shims.

Fixes #1832.

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #1884 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1884      +/-   ##
==========================================
+ Coverage   91.22%   91.24%   +0.01%     
==========================================
  Files         196      196              
  Lines       10745    10745              
  Branches     1574     1574              
==========================================
+ Hits         9802     9804       +2     
+ Misses        943      941       -2
Impacted Files Coverage Δ
lib/atom/decoration.js 85.54% <0%> (+1.2%) ⬆️
lib/atom/gutter.js 92.3% <0%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391514c...b21a9e7. Read the comment docs.

@smashwilson
Copy link
Contributor Author

Oh, right, this probably needs #1885.

Copy link

@annthurium annthurium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to do any manual testing? Or are you pretty confident that the newest versions of these libs aren't gonna break anything??

also, is this the version with hooks??

@smashwilson
Copy link
Contributor Author

do we need to do any manual testing? Or are you pretty confident that the newest versions of these libs aren't gonna break anything??

For React, yeah, I was going to at least take it for a spin and make sure it runs. Our tests should catch anything that regressed, but just to be sure.

also, is this the version with hooks??

lol

screen shot 2019-01-04 at 6 21 23 pm

@smashwilson smashwilson requested a review from a team January 8, 2019 15:57
@smashwilson
Copy link
Contributor Author

I fired it up and clicking around a bit and it looks like we're still good 👌

Copy link

@annthurium annthurium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, let's ship it! Thanks for doing the manual testing.

@smashwilson smashwilson merged commit 58a6f13 into master Jan 8, 2019
@smashwilson smashwilson deleted the aw/react-up branch January 8, 2019 18:21
@kuychaco kuychaco mentioned this pull request Feb 4, 2019
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants