Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Conversation

@smashwilson
Copy link
Contributor

This is me running through npm outdated and updating everything in devDependencies to @latest at once. Because these are all dev dependencies, a green build and proper coverage reporting are strong indicators that this is fine to do.

@smashwilson smashwilson requested a review from a team January 9, 2019 00:48
@codecov
Copy link

codecov bot commented Jan 9, 2019

Codecov Report

Merging #1891 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
+ Coverage   91.07%   91.08%   +0.01%     
==========================================
  Files         185      185              
  Lines       10639    10719      +80     
  Branches     1575     1575              
==========================================
+ Hits         9689     9763      +74     
- Misses        950      956       +6
Impacted Files Coverage Δ
lib/views/pr-commits-view.js 58.33% <0%> (-8.34%) ⬇️
lib/models/author.js 66.03% <0%> (-6.69%) ⬇️
lib/models/operation-state-observer.js 97.14% <0%> (-2.86%) ⬇️
lib/models/commit.js 91.91% <0%> (-2.77%) ⬇️
lib/composite-git-strategy.js 100% <0%> (ø) ⬆️
lib/models/remote.js 100% <0%> (ø) ⬆️
lib/atom/uri-pattern.js 100% <0%> (ø) ⬆️
lib/controllers/issue-timeline-controller.js 0% <0%> (ø) ⬆️
lib/models/patch/file.js 100% <0%> (ø) ⬆️
lib/controllers/pr-timeline-controller.js 33.33% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a6f13...5a899aa. Read the comment docs.

@smashwilson smashwilson merged commit f3971dc into master Jan 9, 2019
@smashwilson smashwilson deleted the aw/dev-deps-up branch January 9, 2019 03:13
@kuychaco kuychaco mentioned this pull request Feb 4, 2019
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants