event added for ClientCharacterVisualization on destroy to remove UI elements #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernando-cortez
added
2-Easy
pdeschain
approved these changes
Mar 22, 2021
pdeschain
added
2-One More Review
SamuelBellomo
approved these changes
Mar 23, 2021
SamuelBellomo
added a commit
that referenced
this pull request
Mar 23, 2021
* release/v0.1.0-experimental: event added for ClientCharacterVisualization on destroy to remove UI elements (#190) Feature/template cleanup (#177) adding a simplified version of my animation_anticipation change that … (#182) cleanup for downed player on late join (order of operations) & health check (#174) update mlapi version (#183) Removed unused component reference from CharLight (5) game object, (#189) redundant meta files removed ReadMe update with Discord Channel awareness (#186) Update LFS content in README (#151) ready button disabled sprite field updated (#178) fix: Remove development test scenes (#179) Update CONTRIBUTING.md Sam's comments # version update (#170) # Conflicts: # Assets/BossRoom/Scenes/BossRoom.unity # Assets/BossRoom/Scenes/CharSelect.unity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira bug task here.
PCs which are not the local player (aka allies) subscribe to an event on destroy to remove itself from the PartyHUD UI. Reference to the parent's NetworkObjectID is cached since the parent's GameObject could be destroyed before this GameObject.