Skip to content

Conversation

@pdeschain
Copy link
Contributor

@pdeschain pdeschain commented Mar 19, 2021

Removed unused component reference from CharLight (5) game object.
While going through the warnings discovered a bug in MLAPI that was reported to the SDK team (discussed in slack thread: https://unity.slack.com/archives/C01P4R0S2QH/p1616098936079500 )

Otherwise I have also discovered a list of art assets that need some tweaking by Stormflag:

Shader warning in 'Custom/S_SimpleDissolve': floating point division by zero at line 102 (on d3d11)

Compiling Fragment program with POINT
Platform defines: UNITY_ENABLE_REFLECTION_BUFFERS UNITY_USE_DITHER_MASK_FOR_ALPHABLENDED_SHADOWS UNITY_PBS_USE_BRDF1 UNITY_SPECCUBE_BOX_PROJECTION UNITY_SPECCUBE_BLENDING UNITY_ENABLE_DETAIL_NORMALMAP SHADER_API_DESKTOP UNITY_LIGHT_PROBE_PROXY_VOLUME UNITY_LIGHTMAP_FULL_HDR UNITY_PASS_FORWARDADD
Disabled keywords: FOG_LINEAR FOG_EXP FOG_EXP2 _USEALPHACHANNEL_ON _HASFLOWEFFECT_ON _HASMASK_ON _VERTEXAOPACITY_ON _HASTEXTUREDISSOLVE_ON _STEPSUBTRACT_ON _HASDYNAMICDISSOLVE_ON _HASDOUBLEMASK_ON _INVERTMASK_ON _CHANGEMASKTOX_ON DIRECTIONAL SPOT POINT_COOKIE DIRECTIONAL_COOKIE UNITY_NO_DXT5nm UNITY_ENABLE_NATIVE_SHADOW_LOOKUPS UNITY_METAL_SHADOWS_USE_POINT_FILTERING UNITY_NO_SCREENSPACE_SHADOWS UNITY_PBS_USE_BRDF2 UNITY_PBS_USE_BRDF3 UNITY_NO_FULL_STANDARD_SHADER UNITY_HARDWARE_TIER1 UNITY_HARDWARE_TIER2 UNITY_HARDWARE_TIER3 UNITY_COLORSPACE_GAMMA UNITY_HALF_PRECISION_FRAGMENT_SHADER_REGISTERS UNITY_LIGHTMAP_DLDR_ENCODING UNITY_LIGHTMAP_RGBM_ENCODING UNITY_VIRTUAL_TEXTURING UNITY_PRETRANSFORM_TO_DISPLAY_ORIENTATION UNITY_ASTC_NORMALMAP_ENCODING SHADER_API_GLES30


A polygon of Mesh 'Boss_Helmet' in Assets/BossRoom/Models/CharacterSet.fbx is self-intersecting and has been discarded.

A polygon of Mesh 'Boss_Helmet' in Assets/BossRoom/Models/CharacterSet.fbx is self-intersecting and has been discarded.

A polygon of Mesh 'door_gears' in Assets/BossRoom/Models/Animated/door_gears_ani.FBX is self-intersecting and has been discarded.

A polygon of Mesh 'door_boss' in Assets/BossRoom/Models/Animated/door_boss_ani.FBX is self-intersecting and has been discarded.

A polygon of Mesh 'door_boss' in Assets/BossRoom/Models/Animated/door_boss_ani.FBX is self-intersecting and has been discarded.

A polygon of Mesh 'wall1_base_straight_1' in Assets/BossRoom/Models/DungeonPieces.FBX is self-intersecting and has been discarded.

A polygon of Mesh 'wall1_base_straight_2' in Assets/BossRoom/Models/DungeonPieces.FBX is self-intersecting and has been discarded.

A polygon of Mesh 'Pillar2_piece20' in Assets/BossRoom/Models/DungeonPieces.FBX is self-intersecting and has been discarded.

A polygon of Mesh 'Pillar2_piece20' in Assets/BossRoom/Models/DungeonPieces.FBX is self-intersecting and has been discarded.

A polygon of Mesh 'Pillar2_piece02' in Assets/BossRoom/Models/DungeonPieces.FBX is self-intersecting and has been discarded.

A polygon of Mesh 'wall1_base_straight_3' in Assets/BossRoom/Models/DungeonPieces.FBX is self-intersecting and has been discarded.

Split Animation Take Not Found 'Take 001'

@pdeschain pdeschain added the 2-Easy This PR is trivial and can be reviewed quickly label Mar 19, 2021
@SamuelBellomo SamuelBellomo merged commit 5e6f476 into release/v0.1.0-experimental Mar 19, 2021
@SamuelBellomo SamuelBellomo deleted the feature/warnings-cleanup branch March 19, 2021 19:22
SamuelBellomo added a commit that referenced this pull request Mar 23, 2021
* release/v0.1.0-experimental:
  event added for ClientCharacterVisualization on destroy to remove UI elements (#190)
  Feature/template cleanup (#177)
  adding a simplified version of my animation_anticipation change that … (#182)
  cleanup for downed player on late join (order of operations) & health check (#174)
  update mlapi version (#183)
  Removed unused component reference from CharLight (5) game object, (#189)
  redundant meta files removed
  ReadMe update with Discord Channel awareness (#186)
  Update LFS content in README (#151)
  ready button disabled sprite field updated (#178)
  fix: Remove development test scenes (#179)
  Update CONTRIBUTING.md
  Sam's comments
  #
  version update (#170)

# Conflicts:
#	Assets/BossRoom/Scenes/BossRoom.unity
#	Assets/BossRoom/Scenes/CharSelect.unity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants