Skip to content

Conversation

@lkrell
Copy link
Contributor

@lkrell lkrell commented Mar 9, 2021

Updated LFS content with call out, link, and commands to help highlight the info. Feedback from bug bash was devs didn't find the info easily, and would like it called out.

MTTDOC-113 Jira ticket

@lkrell lkrell marked this pull request as ready for review March 9, 2021 21:23
@SamuelBellomo SamuelBellomo added the 1-Needs Review PR needs attention from the assignee and reviewers label Mar 10, 2021
@pdeschain pdeschain added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 10, 2021
pdeschain
pdeschain previously approved these changes Mar 10, 2021
SamuelBellomo
SamuelBellomo previously approved these changes Mar 10, 2021
Copy link
Contributor

@SamuelBellomo SamuelBellomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving once the brew command is fixed

@SamuelBellomo SamuelBellomo added the 2-Reviewed with Comments PR requires owner's attention label Mar 10, 2021
@pdeschain
Copy link
Contributor

@lkrell please resolve conflicts and it's good to merge!

@pdeschain pdeschain added 3-Good to Merge and removed 2-One More Review One review in, one to go 2-Reviewed with Comments PR requires owner's attention labels Mar 11, 2021
@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Mar 11, 2021
@lkrell lkrell dismissed stale reviews from SamuelBellomo and pdeschain via 400e731 March 15, 2021 19:37
@lkrell
Copy link
Contributor Author

lkrell commented Mar 15, 2021

@pdeschain Sorry for wait, updated per review thanks!

@pdeschain pdeschain added 2-Reviewed with Comments PR requires owner's attention and removed 3-Good to Merge labels Mar 15, 2021
@SamuelBellomo
Copy link
Contributor

also, this should be merged to our release branch, not develop anymore

@lkrell lkrell changed the base branch from develop to release/v0.1.0-experimental March 18, 2021 13:53
@lkrell
Copy link
Contributor Author

lkrell commented Mar 18, 2021

Updated base and removed the mac commands.

@pdeschain pdeschain removed the 2-Reviewed with Comments PR requires owner's attention label Mar 18, 2021
@pdeschain pdeschain added the 2-One More Review One review in, one to go label Mar 18, 2021
@SamuelBellomo SamuelBellomo merged commit f0dd033 into release/v0.1.0-experimental Mar 18, 2021
@SamuelBellomo SamuelBellomo deleted the mttdoc113-lfs-content branch March 18, 2021 21:54
SamuelBellomo added a commit that referenced this pull request Mar 23, 2021
* release/v0.1.0-experimental:
  event added for ClientCharacterVisualization on destroy to remove UI elements (#190)
  Feature/template cleanup (#177)
  adding a simplified version of my animation_anticipation change that … (#182)
  cleanup for downed player on late join (order of operations) & health check (#174)
  update mlapi version (#183)
  Removed unused component reference from CharLight (5) game object, (#189)
  redundant meta files removed
  ReadMe update with Discord Channel awareness (#186)
  Update LFS content in README (#151)
  ready button disabled sprite field updated (#178)
  fix: Remove development test scenes (#179)
  Update CONTRIBUTING.md
  Sam's comments
  #
  version update (#170)

# Conflicts:
#	Assets/BossRoom/Scenes/BossRoom.unity
#	Assets/BossRoom/Scenes/CharSelect.unity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 2-One More Review One review in, one to go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants