Skip to content

Conversation

@fernando-cortez
Copy link
Contributor

Jira bug task.

Order of operations fix on fainted player on late join. Animator was swapped out after an animation trigger had been set. Similarly, health bar is only displayed if health above 0 on late join.

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 16, 2021
@pdeschain pdeschain added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 19, 2021
@fernando-cortez fernando-cortez merged commit ffd082d into release/v0.1.0-experimental Mar 19, 2021
SamuelBellomo added a commit that referenced this pull request Mar 23, 2021
* release/v0.1.0-experimental:
  event added for ClientCharacterVisualization on destroy to remove UI elements (#190)
  Feature/template cleanup (#177)
  adding a simplified version of my animation_anticipation change that … (#182)
  cleanup for downed player on late join (order of operations) & health check (#174)
  update mlapi version (#183)
  Removed unused component reference from CharLight (5) game object, (#189)
  redundant meta files removed
  ReadMe update with Discord Channel awareness (#186)
  Update LFS content in README (#151)
  ready button disabled sprite field updated (#178)
  fix: Remove development test scenes (#179)
  Update CONTRIBUTING.md
  Sam's comments
  #
  version update (#170)

# Conflicts:
#	Assets/BossRoom/Scenes/BossRoom.unity
#	Assets/BossRoom/Scenes/CharSelect.unity
@fernando-cortez fernando-cortez deleted the feature/fainted-player-hotfix branch March 25, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants