-
Notifications
You must be signed in to change notification settings - Fork 315
Align CSS health metrics #9444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align CSS health metrics #9444
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: d4c8595 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~d4c8595580, baseline=1.53.0-SNAPSHOT~e2e00cd840
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059382
Total [baseline] (10.847 s) : 0, 10846846
Agent [candidate] (1.053 s) : 0, 1052563
Total [candidate] (10.84 s) : 0, 10840273
section appsec
Agent [baseline] (1.228 s) : 0, 1228420
Total [baseline] (10.839 s) : 0, 10839127
Agent [candidate] (1.236 s) : 0, 1235666
Total [candidate] (10.821 s) : 0, 10821420
section iast
Agent [baseline] (1.183 s) : 0, 1183128
Total [baseline] (11.09 s) : 0, 11089589
Agent [candidate] (1.209 s) : 0, 1209371
Total [candidate] (11.11 s) : 0, 11110143
section profiling
Agent [baseline] (1.217 s) : 0, 1217427
Total [baseline] (11.08 s) : 0, 11079829
Agent [candidate] (1.211 s) : 0, 1210719
Total [candidate] (11.079 s) : 0, 11078634
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~d4c8595580, baseline=1.53.0-SNAPSHOT~e2e00cd840
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (740.576 ms) : 0, 740576
BytebuddyAgent [candidate] (734.838 ms) : 0, 734838
GlobalTracer [baseline] (245.624 ms) : 0, 245624
GlobalTracer [candidate] (243.844 ms) : 0, 243844
AppSec [baseline] (30.549 ms) : 0, 30549
AppSec [candidate] (30.182 ms) : 0, 30182
Debugger [baseline] (6.151 ms) : 0, 6151
Debugger [candidate] (6.049 ms) : 0, 6049
Remote Config [baseline] (685.752 µs) : 0, 686
Remote Config [candidate] (665.533 µs) : 0, 666
Telemetry [baseline] (13.152 ms) : 0, 13152
Telemetry [candidate] (14.407 ms) : 0, 14407
section appsec
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (758.846 ms) : 0, 758846
BytebuddyAgent [candidate] (763.635 ms) : 0, 763635
GlobalTracer [baseline] (236.508 ms) : 0, 236508
GlobalTracer [candidate] (237.961 ms) : 0, 237961
IAST [baseline] (23.659 ms) : 0, 23659
IAST [candidate] (23.912 ms) : 0, 23912
AppSec [baseline] (168.805 ms) : 0, 168805
AppSec [candidate] (171.665 ms) : 0, 171665
Debugger [baseline] (8.07 ms) : 0, 8070
Debugger [candidate] (5.784 ms) : 0, 5784
Remote Config [baseline] (626.316 µs) : 0, 626
Remote Config [candidate] (634.476 µs) : 0, 634
Telemetry [baseline] (9.19 ms) : 0, 9190
Telemetry [candidate] (9.24 ms) : 0, 9240
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (852.919 ms) : 0, 852919
BytebuddyAgent [candidate] (874.662 ms) : 0, 874662
GlobalTracer [baseline] (235.151 ms) : 0, 235151
GlobalTracer [candidate] (238.504 ms) : 0, 238504
IAST [baseline] (27.957 ms) : 0, 27957
IAST [candidate] (28.415 ms) : 0, 28415
AppSec [baseline] (28.092 ms) : 0, 28092
AppSec [candidate] (27.421 ms) : 0, 27421
Debugger [baseline] (7.387 ms) : 0, 7387
Debugger [candidate] (8.427 ms) : 0, 8427
Remote Config [baseline] (616.686 µs) : 0, 617
Remote Config [candidate] (616.807 µs) : 0, 617
Telemetry [baseline] (8.317 ms) : 0, 8317
Telemetry [candidate] (8.471 ms) : 0, 8471
section profiling
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (775.7 ms) : 0, 775700
BytebuddyAgent [candidate] (770.301 ms) : 0, 770301
GlobalTracer [baseline] (225.937 ms) : 0, 225937
GlobalTracer [candidate] (224.534 ms) : 0, 224534
AppSec [baseline] (30.683 ms) : 0, 30683
AppSec [candidate] (30.425 ms) : 0, 30425
Debugger [baseline] (7.169 ms) : 0, 7169
Debugger [candidate] (6.396 ms) : 0, 6396
Remote Config [baseline] (737.813 µs) : 0, 738
Remote Config [candidate] (724.792 µs) : 0, 725
Telemetry [baseline] (15.703 ms) : 0, 15703
Telemetry [candidate] (16.491 ms) : 0, 16491
ProfilingAgent [baseline] (108.883 ms) : 0, 108883
ProfilingAgent [candidate] (109.65 ms) : 0, 109650
Profiling [baseline] (109.556 ms) : 0, 109556
Profiling [candidate] (110.304 ms) : 0, 110304
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~d4c8595580, baseline=1.53.0-SNAPSHOT~e2e00cd840
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.052 s) : 0, 1052040
Total [baseline] (8.671 s) : 0, 8670732
Agent [candidate] (1.052 s) : 0, 1052098
Total [candidate] (8.657 s) : 0, 8657109
section iast
Agent [baseline] (1.184 s) : 0, 1183935
Total [baseline] (9.38 s) : 0, 9379956
Agent [candidate] (1.182 s) : 0, 1181718
Total [candidate] (9.382 s) : 0, 9382020
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~d4c8595580, baseline=1.53.0-SNAPSHOT~e2e00cd840
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.494 ms) : 0, 1494
BytebuddyAgent [baseline] (735.618 ms) : 0, 735618
BytebuddyAgent [candidate] (735.556 ms) : 0, 735556
GlobalTracer [baseline] (244.077 ms) : 0, 244077
GlobalTracer [candidate] (244.003 ms) : 0, 244003
AppSec [baseline] (30.18 ms) : 0, 30180
AppSec [candidate] (30.101 ms) : 0, 30101
Debugger [baseline] (6.077 ms) : 0, 6077
Debugger [candidate] (6.076 ms) : 0, 6076
Remote Config [baseline] (666.435 µs) : 0, 666
Remote Config [candidate] (658.71 µs) : 0, 659
Telemetry [baseline] (12.962 ms) : 0, 12962
Telemetry [candidate] (13.126 ms) : 0, 13126
section iast
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (854.095 ms) : 0, 854095
BytebuddyAgent [candidate] (852.339 ms) : 0, 852339
GlobalTracer [baseline] (234.163 ms) : 0, 234163
GlobalTracer [candidate] (234.759 ms) : 0, 234759
AppSec [baseline] (27.737 ms) : 0, 27737
AppSec [candidate] (28.573 ms) : 0, 28573
Debugger [baseline] (5.795 ms) : 0, 5795
Debugger [candidate] (5.751 ms) : 0, 5751
Remote Config [baseline] (607.422 µs) : 0, 607
Remote Config [candidate] (598.871 µs) : 0, 599
Telemetry [baseline] (8.315 ms) : 0, 8315
Telemetry [candidate] (8.384 ms) : 0, 8384
IAST [baseline] (30.625 ms) : 0, 30625
IAST [candidate] (28.841 ms) : 0, 28841
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d4c8595580, baseline=1.53.0-SNAPSHOT~e2e00cd840
dateFormat X
axisFormat %s
section baseline
no_agent (4.322 ms) : 4271, 4372
. : milestone, 4322,
iast (9.376 ms) : 9223, 9530
. : milestone, 9376,
iast_FULL (13.529 ms) : 13265, 13793
. : milestone, 13529,
iast_GLOBAL (10.478 ms) : 10288, 10667
. : milestone, 10478,
profiling (8.931 ms) : 8792, 9069
. : milestone, 8931,
tracing (7.796 ms) : 7682, 7909
. : milestone, 7796,
section candidate
no_agent (4.45 ms) : 4401, 4498
. : milestone, 4450,
iast (9.456 ms) : 9301, 9611
. : milestone, 9456,
iast_FULL (13.709 ms) : 13445, 13973
. : milestone, 13709,
iast_GLOBAL (10.161 ms) : 9968, 10355
. : milestone, 10161,
profiling (8.628 ms) : 8495, 8761
. : milestone, 8628,
tracing (7.438 ms) : 7327, 7550
. : milestone, 7438,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d4c8595580, baseline=1.53.0-SNAPSHOT~e2e00cd840
dateFormat X
axisFormat %s
section baseline
no_agent (37.897 ms) : 37578, 38216
. : milestone, 37897,
appsec (48.529 ms) : 48109, 48950
. : milestone, 48529,
code_origins (45.275 ms) : 44888, 45661
. : milestone, 45275,
iast (44.514 ms) : 44136, 44892
. : milestone, 44514,
profiling (48.493 ms) : 48009, 48977
. : milestone, 48493,
tracing (44.324 ms) : 43950, 44697
. : milestone, 44324,
section candidate
no_agent (37.257 ms) : 36956, 37557
. : milestone, 37257,
appsec (46.23 ms) : 45819, 46640
. : milestone, 46230,
code_origins (44.812 ms) : 44442, 45181
. : milestone, 44812,
iast (45.87 ms) : 45463, 46278
. : milestone, 45870,
profiling (47.397 ms) : 46958, 47836
. : milestone, 47397,
tracing (44.439 ms) : 44062, 44817
. : milestone, 44439,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d4c8595580, baseline=1.53.0-SNAPSHOT~e2e00cd840
dateFormat X
axisFormat %s
section baseline
no_agent (15.553 s) : 15553000, 15553000
. : milestone, 15553000,
appsec (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
iast (18.426 s) : 18426000, 18426000
. : milestone, 18426000,
iast_GLOBAL (18.222 s) : 18222000, 18222000
. : milestone, 18222000,
profiling (15.379 s) : 15379000, 15379000
. : milestone, 15379000,
tracing (14.969 s) : 14969000, 14969000
. : milestone, 14969000,
section candidate
no_agent (15.695 s) : 15695000, 15695000
. : milestone, 15695000,
appsec (14.964 s) : 14964000, 14964000
. : milestone, 14964000,
iast (18.445 s) : 18445000, 18445000
. : milestone, 18445000,
iast_GLOBAL (18.073 s) : 18073000, 18073000
. : milestone, 18073000,
profiling (15.353 s) : 15353000, 15353000
. : milestone, 15353000,
tracing (14.899 s) : 14899000, 14899000
. : milestone, 14899000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d4c8595580, baseline=1.53.0-SNAPSHOT~e2e00cd840
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.571 ms) : 3361, 3780
. : milestone, 3571,
iast (2.195 ms) : 2132, 2258
. : milestone, 2195,
iast_GLOBAL (2.239 ms) : 2176, 2302
. : milestone, 2239,
profiling (2.064 ms) : 2012, 2117
. : milestone, 2064,
tracing (2.01 ms) : 1961, 2059
. : milestone, 2010,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.608 ms) : 3397, 3819
. : milestone, 3608,
iast (2.195 ms) : 2132, 2257
. : milestone, 2195,
iast_GLOBAL (2.246 ms) : 2183, 2310
. : milestone, 2246,
profiling (2.032 ms) : 1982, 2083
. : milestone, 2032,
tracing (2.013 ms) : 1964, 2062
. : milestone, 2013,
|
dd-trace-core/src/main/java/datadog/trace/core/monitor/TracerHealthMetrics.java
Show resolved
Hide resolved
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#​9355](DataDog/dd-trace-java#9355) - [@​jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#​9310](DataDog/dd-trace-java#9310) - [@​jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#​9294](DataDog/dd-trace-java#9294) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#​9204](DataDog/dd-trace-java#9204) - [@​sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#​9425](DataDog/dd-trace-java#9425) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#​9318](DataDog/dd-trace-java#9318) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#​9278](DataDog/dd-trace-java#9278) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#​9337](DataDog/dd-trace-java#9337) - [@​luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#​9449](DataDog/dd-trace-java#9449) - [@​amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#​9444](DataDog/dd-trace-java#9444) - [@​amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#​9442](DataDog/dd-trace-java#9442) - [@​amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#​9377](DataDog/dd-trace-java#9377) - [@​amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#​9178](DataDog/dd-trace-java#9178) - [@​bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#​9433](DataDog/dd-trace-java#9433) - [@​MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#​9401](DataDog/dd-trace-java#9401) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#​9334](DataDog/dd-trace-java#9334) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#​9392](DataDog/dd-trace-java#9392) - [@​amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#​9333](DataDog/dd-trace-java#9333) - [@​amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#​9323](DataDog/dd-trace-java#9323) - [@​amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#​9267](DataDog/dd-trace-java#9267) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#​9184](DataDog/dd-trace-java#9184) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#​9459](DataDog/dd-trace-java#9459) - [@​ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#​9299](DataDog/dd-trace-java#9299) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#​9244](DataDog/dd-trace-java#9244) - [@​mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#​9384](DataDog/dd-trace-java#9384), [#​9378](DataDog/dd-trace-java#9378), [#​9358](DataDog/dd-trace-java#9358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#​9289](DataDog/dd-trace-java#9289) - [@​rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#​9211](DataDog/dd-trace-java#9211) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#​9458](DataDog/dd-trace-java#9458) - [@​amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#​9408](DataDog/dd-trace-java#9408) - [@​amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#​9387](DataDog/dd-trace-java#9387) - [@​cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#​9370](DataDog/dd-trace-java#9370) - [@​mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#​9353](DataDog/dd-trace-java#9353) - [@​amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#​9259](DataDog/dd-trace-java#9259) - [@​mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#​9367](DataDog/dd-trace-java#9367) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#​9403](DataDog/dd-trace-java#9403) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#​9412](DataDog/dd-trace-java#9412) - [@​cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8
What Does This Do
Fix naming on CSS health metrics and add base tags
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]