Skip to content

Commit d4c8595

Browse files
committed
Base tags are already added by statsd
1 parent fb4ca13 commit d4c8595

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

dd-trace-core/src/main/java/datadog/trace/core/monitor/TracerHealthMetrics.java

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package datadog.trace.core.monitor;
22

3-
import static datadog.communication.ddagent.TracerVersion.TRACER_VERSION;
43
import static datadog.trace.api.DDSpanId.ZERO;
54
import static datadog.trace.api.sampling.PrioritySampling.SAMPLER_DROP;
65
import static datadog.trace.api.sampling.PrioritySampling.SAMPLER_KEEP;
@@ -10,7 +9,6 @@
109
import static datadog.trace.bootstrap.instrumentation.api.Tags.SPAN_KIND_CLIENT;
1110
import static java.util.concurrent.TimeUnit.SECONDS;
1211

13-
import datadog.trace.api.Config;
1412
import datadog.trace.api.StatsDClient;
1513
import datadog.trace.api.cache.RadixTreeCache;
1614
import datadog.trace.common.writer.RemoteApi;
@@ -35,10 +33,6 @@ public class TracerHealthMetrics extends HealthMetrics implements AutoCloseable
3533
private static final String[] STATUS_OK_TAGS = STATUS_TAGS.apply(200);
3634
private final RadixTreeCache<String[]> statusTagsCache =
3735
new RadixTreeCache<>(16, 32, STATUS_TAGS, 200, 400);
38-
private static final String[] BASE_TAGS =
39-
new String[] {
40-
"lang:java", "env:" + Config.get().getEnv(), "tracer_version:" + TRACER_VERSION
41-
};
4236

4337
private final AtomicBoolean started = new AtomicBoolean(false);
4438
private volatile AgentTaskScheduler.Scheduled<TracerHealthMetrics> cancellation;
@@ -535,18 +529,16 @@ public void run(TracerHealthMetrics target) {
535529
target.statsd, "long-running.expired", target.longRunningTracesExpired, NO_TAGS);
536530

537531
reportIfChanged(
538-
target.statsd, "stats.traces_in", target.clientStatsProcessedTraces, BASE_TAGS);
532+
target.statsd, "stats.traces_in", target.clientStatsProcessedTraces, NO_TAGS);
533+
reportIfChanged(target.statsd, "stats.spans_in", target.clientStatsProcessedSpans, NO_TAGS);
539534
reportIfChanged(
540-
target.statsd, "stats.spans_in", target.clientStatsProcessedSpans, BASE_TAGS);
535+
target.statsd, "stats.dropped_p0_traces", target.clientStatsP0DroppedTraces, NO_TAGS);
541536
reportIfChanged(
542-
target.statsd, "stats.dropped_p0_traces", target.clientStatsP0DroppedTraces, BASE_TAGS);
537+
target.statsd, "stats.dropped_p0_spans", target.clientStatsP0DroppedSpans, NO_TAGS);
538+
reportIfChanged(target.statsd, "stats.flush_payloads", target.clientStatsRequests, NO_TAGS);
539+
reportIfChanged(target.statsd, "stats.flush_errors", target.clientStatsErrors, NO_TAGS);
543540
reportIfChanged(
544-
target.statsd, "stats.dropped_p0_spans", target.clientStatsP0DroppedSpans, BASE_TAGS);
545-
reportIfChanged(
546-
target.statsd, "stats.flush_payloads", target.clientStatsRequests, BASE_TAGS);
547-
reportIfChanged(target.statsd, "stats.flush_errors", target.clientStatsErrors, BASE_TAGS);
548-
reportIfChanged(
549-
target.statsd, "stats.agent_downgrades", target.clientStatsDowngrades, BASE_TAGS);
541+
target.statsd, "stats.agent_downgrades", target.clientStatsDowngrades, NO_TAGS);
550542

551543
} catch (ArrayIndexOutOfBoundsException e) {
552544
log.warn(

0 commit comments

Comments
 (0)