Avoid NPE on featureDiscovery creation #9353

amarziali · 2025-08-12T11:58:47Z

What Does This Do

Fixes NPE like

java.lang.NullPointerException: Cannot invoke "datadog.communication.ddagent.DDAgentFeaturesDiscovery.discoverIfOutdated()" because "this.ddAgentFeaturesDiscovery" is null

linked to the fact that, if the object is created in parallel, the non-first call will return null.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java

datadog-datadog-prod-us1 · 2025-08-12T12:26:16Z

Code coverage: total 59.00%, base diff 1.68%, patch 100.00% (view details)

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 67ccb2e | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-08-12T12:39:39Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/fix-npe
git_commit_date	1754981571	1755000378
git_commit_sha	`23cacab`	`67ccb2e`
release_version	1.53.0-SNAPSHOT~23cacab9e5	1.53.0-SNAPSHOT~67ccb2e820

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755002083	1755002083
ci_job_id	1075858382	1075858382
ci_pipeline_id	73401848	73401848
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-uv6fa7qt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-uv6fa7qt 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~67ccb2e820, baseline=1.53.0-SNAPSHOT~23cacab9e5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043780
Total [baseline] (8.569 s) : 0, 8569447
Agent [candidate] (1.052 s) : 0, 1051591
Total [candidate] (8.578 s) : 0, 8577514
section iast
Agent [baseline] (1.176 s) : 0, 1175929
Total [baseline] (9.299 s) : 0, 9298572
Agent [candidate] (1.177 s) : 0, 1177372
Total [candidate] (9.319 s) : 0, 9318847

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.176 s	132.149 ms (12.7%)
Total	tracing	8.569 s	-
Total	iast	9.299 s	729.124 ms (8.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.052 s	-
Agent	iast	1.177 s	125.781 ms (12.0%)
Total	tracing	8.578 s	-
Total	iast	9.319 s	741.333 ms (8.6%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~67ccb2e820, baseline=1.53.0-SNAPSHOT~23cacab9e5

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (731.02 ms) : 0, 731020
BytebuddyAgent [candidate] (737.278 ms) : 0, 737278
GlobalTracer [baseline] (241.493 ms) : 0, 241493
GlobalTracer [candidate] (243.319 ms) : 0, 243319
AppSec [baseline] (30.051 ms) : 0, 30051
AppSec [candidate] (30.262 ms) : 0, 30262
Debugger [baseline] (6.041 ms) : 0, 6041
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (650.056 µs) : 0, 650
Remote Config [candidate] (655.827 µs) : 0, 656
Telemetry [baseline] (12.127 ms) : 0, 12127
Telemetry [candidate] (11.552 ms) : 0, 11552
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.421 ms) : 0, 1421
BytebuddyAgent [baseline] (849.424 ms) : 0, 849424
BytebuddyAgent [candidate] (850.295 ms) : 0, 850295
GlobalTracer [baseline] (232.41 ms) : 0, 232410
GlobalTracer [candidate] (232.483 ms) : 0, 232483
IAST [baseline] (29.805 ms) : 0, 29805
IAST [candidate] (30.966 ms) : 0, 30966
AppSec [baseline] (27.185 ms) : 0, 27185
AppSec [candidate] (25.778 ms) : 0, 25778
Debugger [baseline] (5.763 ms) : 0, 5763
Debugger [candidate] (6.598 ms) : 0, 6598
Remote Config [baseline] (610.087 µs) : 0, 610
Remote Config [candidate] (574.122 µs) : 0, 574
Telemetry [baseline] (8.347 ms) : 0, 8347
Telemetry [candidate] (8.315 ms) : 0, 8315

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~67ccb2e820, baseline=1.53.0-SNAPSHOT~23cacab9e5

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.043 s) : 0, 1042885
Total [baseline] (10.716 s) : 0, 10716297
Agent [candidate] (1.051 s) : 0, 1050991
Total [candidate] (10.802 s) : 0, 10802138
section appsec
Agent [baseline] (1.221 s) : 0, 1221097
Total [baseline] (10.763 s) : 0, 10763397
Agent [candidate] (1.229 s) : 0, 1229491
Total [candidate] (10.823 s) : 0, 10823405
section iast
Agent [baseline] (1.192 s) : 0, 1191848
Total [baseline] (10.969 s) : 0, 10968547
Agent [candidate] (1.185 s) : 0, 1185141
Total [candidate] (10.871 s) : 0, 10871329
section profiling
Agent [baseline] (1.192 s) : 0, 1191802
Total [baseline] (10.863 s) : 0, 10862767
Agent [candidate] (1.194 s) : 0, 1193632
Total [candidate] (10.804 s) : 0, 10804405

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.043 s	-
Agent	appsec	1.221 s	178.212 ms (17.1%)
Agent	iast	1.192 s	148.963 ms (14.3%)
Agent	profiling	1.192 s	148.917 ms (14.3%)
Total	tracing	10.716 s	-
Total	appsec	10.763 s	47.099 ms (0.4%)
Total	iast	10.969 s	252.25 ms (2.4%)
Total	profiling	10.863 s	146.47 ms (1.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.051 s	-
Agent	appsec	1.229 s	178.5 ms (17.0%)
Agent	iast	1.185 s	134.15 ms (12.8%)
Agent	profiling	1.194 s	142.641 ms (13.6%)
Total	tracing	10.802 s	-
Total	appsec	10.823 s	21.267 ms (0.2%)
Total	iast	10.871 s	69.191 ms (0.6%)
Total	profiling	10.804 s	2.266 ms (0.0%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~67ccb2e820, baseline=1.53.0-SNAPSHOT~23cacab9e5

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.431 ms) : 0, 1431
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (729.739 ms) : 0, 729739
BytebuddyAgent [candidate] (736.374 ms) : 0, 736374
GlobalTracer [baseline] (241.317 ms) : 0, 241317
GlobalTracer [candidate] (243.533 ms) : 0, 243533
AppSec [baseline] (30.058 ms) : 0, 30058
AppSec [candidate] (30.297 ms) : 0, 30297
Debugger [baseline] (6.029 ms) : 0, 6029
Debugger [candidate] (6.069 ms) : 0, 6069
Remote Config [baseline] (655.803 µs) : 0, 656
Remote Config [candidate] (652.389 µs) : 0, 652
Telemetry [baseline] (12.674 ms) : 0, 12674
Telemetry [candidate] (11.408 ms) : 0, 11408
section appsec
crashtracking [baseline] (1.427 ms) : 0, 1427
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (753.73 ms) : 0, 753730
BytebuddyAgent [candidate] (759.856 ms) : 0, 759856
GlobalTracer [baseline] (235.642 ms) : 0, 235642
GlobalTracer [candidate] (236.687 ms) : 0, 236687
IAST [baseline] (23.513 ms) : 0, 23513
IAST [candidate] (23.711 ms) : 0, 23711
AppSec [baseline] (170.894 ms) : 0, 170894
AppSec [candidate] (169.636 ms) : 0, 169636
Debugger [baseline] (5.74 ms) : 0, 5740
Debugger [candidate] (6.444 ms) : 0, 6444
Remote Config [baseline] (623.823 µs) : 0, 624
Remote Config [candidate] (626.348 µs) : 0, 626
Telemetry [baseline] (8.399 ms) : 0, 8399
Telemetry [candidate] (9.136 ms) : 0, 9136
section iast
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (861.614 ms) : 0, 861614
BytebuddyAgent [candidate] (856.696 ms) : 0, 856696
GlobalTracer [baseline] (235.361 ms) : 0, 235361
GlobalTracer [candidate] (234.393 ms) : 0, 234393
IAST [baseline] (27.898 ms) : 0, 27898
IAST [candidate] (26.727 ms) : 0, 26727
AppSec [baseline] (27.764 ms) : 0, 27764
AppSec [candidate] (27.414 ms) : 0, 27414
Debugger [baseline] (7.508 ms) : 0, 7508
Debugger [candidate] (8.313 ms) : 0, 8313
Remote Config [baseline] (596.688 µs) : 0, 597
Remote Config [candidate] (584.4 µs) : 0, 584
Telemetry [baseline] (8.417 ms) : 0, 8417
Telemetry [candidate] (8.39 ms) : 0, 8390
section profiling
crashtracking [baseline] (1.399 ms) : 0, 1399
crashtracking [candidate] (1.417 ms) : 0, 1417
BytebuddyAgent [baseline] (758.939 ms) : 0, 758939
BytebuddyAgent [candidate] (760.909 ms) : 0, 760909
GlobalTracer [baseline] (221.746 ms) : 0, 221746
GlobalTracer [candidate] (221.331 ms) : 0, 221331
AppSec [baseline] (29.85 ms) : 0, 29850
AppSec [candidate] (29.842 ms) : 0, 29842
Debugger [baseline] (6.286 ms) : 0, 6286
Debugger [candidate] (6.307 ms) : 0, 6307
Remote Config [baseline] (681.867 µs) : 0, 682
Remote Config [candidate] (693.485 µs) : 0, 693
Telemetry [baseline] (16.154 ms) : 0, 16154
Telemetry [candidate] (15.235 ms) : 0, 15235
ProfilingAgent [baseline] (107.43 ms) : 0, 107430
ProfilingAgent [candidate] (108.192 ms) : 0, 108192
Profiling [baseline] (108.061 ms) : 0, 108061
Profiling [candidate] (108.856 ms) : 0, 108856

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/fix-npe
git_commit_date	1754981571	1755000378
git_commit_sha	`23cacab`	`67ccb2e`
release_version	1.53.0-SNAPSHOT~23cacab9e5	1.53.0-SNAPSHOT~67ccb2e820

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755001828	1755001828
ci_job_id	1075858383	1075858383
ci_pipeline_id	73401848	73401848
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-5vvllwck 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-5vvllwck 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	better [-590.640µs; -294.177µs] or [-6.679%; -3.327%]	unstable [-43.752op/s; +98.502op/s] or [-8.343%; +18.782%]	8.401ms	551.812op/s	8.843ms	524.438op/s
scenario:load:petclinic:appsec:high_load	worse [+1.122ms; +1.981ms] or [+2.519%; +4.446%]	unstable [-9.635op/s; +5.230op/s] or [-9.177%; +4.981%]	46.104ms	102.785op/s	44.553ms	104.987op/s
scenario:load:petclinic:profiling:high_load	worse [+2.849ms; +3.798ms] or [+6.376%; +8.500%]	unstable [-13.357op/s; +1.349op/s] or [-12.757%; +1.289%]	48.011ms	98.696op/s	44.687ms	104.700op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~67ccb2e820, baseline=1.53.0-SNAPSHOT~23cacab9e5
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.982 ms) : 36681, 37283
.   : milestone, 36982,
appsec (44.553 ms) : 44163, 44943
.   : milestone, 44553,
code_origins (45.621 ms) : 45234, 46009
.   : milestone, 45621,
iast (45.486 ms) : 45098, 45875
.   : milestone, 45486,
profiling (44.687 ms) : 44294, 45081
.   : milestone, 44687,
tracing (44.878 ms) : 44491, 45266
.   : milestone, 44878,
section candidate
no_agent (36.049 ms) : 35753, 36345
.   : milestone, 36049,
appsec (46.104 ms) : 45697, 46512
.   : milestone, 46104,
code_origins (45.894 ms) : 45495, 46293
.   : milestone, 45894,
iast (44.508 ms) : 44113, 44903
.   : milestone, 44508,
profiling (48.011 ms) : 47527, 48495
.   : milestone, 48011,
tracing (43.586 ms) : 43215, 43958
.   : milestone, 43586,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.982 ms [36.681 ms, 37.283 ms]	-
appsec	44.553 ms [44.163 ms, 44.943 ms]	7.571 ms (20.5%)
code_origins	45.621 ms [45.234 ms, 46.009 ms]	8.639 ms (23.4%)
iast	45.486 ms [45.098 ms, 45.875 ms]	8.504 ms (23.0%)
profiling	44.687 ms [44.294 ms, 45.081 ms]	7.705 ms (20.8%)
tracing	44.878 ms [44.491 ms, 45.266 ms]	7.896 ms (21.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.049 ms [35.753 ms, 36.345 ms]	-
appsec	46.104 ms [45.697 ms, 46.512 ms]	10.056 ms (27.9%)
code_origins	45.894 ms [45.495 ms, 46.293 ms]	9.845 ms (27.3%)
iast	44.508 ms [44.113 ms, 44.903 ms]	8.459 ms (23.5%)
profiling	48.011 ms [47.527 ms, 48.495 ms]	11.962 ms (33.2%)
tracing	43.586 ms [43.215 ms, 43.958 ms]	7.538 ms (20.9%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~67ccb2e820, baseline=1.53.0-SNAPSHOT~23cacab9e5
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.346 ms) : 4292, 4399
.   : milestone, 4346,
iast (8.892 ms) : 8752, 9032
.   : milestone, 8892,
iast_FULL (14.02 ms) : 13738, 14301
.   : milestone, 14020,
iast_GLOBAL (10.208 ms) : 10022, 10394
.   : milestone, 10208,
profiling (8.843 ms) : 8694, 8993
.   : milestone, 8843,
tracing (7.458 ms) : 7355, 7562
.   : milestone, 7458,
section candidate
no_agent (4.381 ms) : 4332, 4431
.   : milestone, 4381,
iast (9.123 ms) : 8971, 9275
.   : milestone, 9123,
iast_FULL (13.836 ms) : 13563, 14109
.   : milestone, 13836,
iast_GLOBAL (10.298 ms) : 10119, 10477
.   : milestone, 10298,
profiling (8.401 ms) : 8276, 8526
.   : milestone, 8401,
tracing (7.38 ms) : 7278, 7483
.   : milestone, 7380,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.346 ms [4.292 ms, 4.399 ms]	-
iast	8.892 ms [8.752 ms, 9.032 ms]	4.546 ms (104.6%)
iast_FULL	14.02 ms [13.738 ms, 14.301 ms]	9.674 ms (222.6%)
iast_GLOBAL	10.208 ms [10.022 ms, 10.394 ms]	5.863 ms (134.9%)
profiling	8.843 ms [8.694 ms, 8.993 ms]	4.498 ms (103.5%)
tracing	7.458 ms [7.355 ms, 7.562 ms]	3.113 ms (71.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.381 ms [4.332 ms, 4.431 ms]	-
iast	9.123 ms [8.971 ms, 9.275 ms]	4.742 ms (108.2%)
iast_FULL	13.836 ms [13.563 ms, 14.109 ms]	9.455 ms (215.8%)
iast_GLOBAL	10.298 ms [10.119 ms, 10.477 ms]	5.916 ms (135.0%)
profiling	8.401 ms [8.276 ms, 8.526 ms]	4.02 ms (91.7%)
tracing	7.38 ms [7.278 ms, 7.483 ms]	2.999 ms (68.5%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/fix-npe
git_commit_date	1754981571	1755000378
git_commit_sha	`23cacab`	`67ccb2e`
release_version	1.53.0-SNAPSHOT~23cacab9e5	1.53.0-SNAPSHOT~67ccb2e820

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755002257	1755002257
ci_job_id	1075858384	1075858384
ci_pipeline_id	73401848	73401848
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-bdhnqm37 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-bdhnqm37 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~67ccb2e820, baseline=1.53.0-SNAPSHOT~23cacab9e5
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.526 s) : 15526000, 15526000
.   : milestone, 15526000,
appsec (14.999 s) : 14999000, 14999000
.   : milestone, 14999000,
iast (18.451 s) : 18451000, 18451000
.   : milestone, 18451000,
iast_GLOBAL (17.989 s) : 17989000, 17989000
.   : milestone, 17989000,
profiling (15.856 s) : 15856000, 15856000
.   : milestone, 15856000,
tracing (15.112 s) : 15112000, 15112000
.   : milestone, 15112000,
section candidate
no_agent (14.981 s) : 14981000, 14981000
.   : milestone, 14981000,
appsec (14.844 s) : 14844000, 14844000
.   : milestone, 14844000,
iast (18.42 s) : 18420000, 18420000
.   : milestone, 18420000,
iast_GLOBAL (18.278 s) : 18278000, 18278000
.   : milestone, 18278000,
profiling (15.361 s) : 15361000, 15361000
.   : milestone, 15361000,
tracing (15.043 s) : 15043000, 15043000
.   : milestone, 15043000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.526 s [15.526 s, 15.526 s]	-
appsec	14.999 s [14.999 s, 14.999 s]	-527.0 ms (-3.4%)
iast	18.451 s [18.451 s, 18.451 s]	2.925 s (18.8%)
iast_GLOBAL	17.989 s [17.989 s, 17.989 s]	2.463 s (15.9%)
profiling	15.856 s [15.856 s, 15.856 s]	330.0 ms (2.1%)
tracing	15.112 s [15.112 s, 15.112 s]	-414.0 ms (-2.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.981 s [14.981 s, 14.981 s]	-
appsec	14.844 s [14.844 s, 14.844 s]	-137.0 ms (-0.9%)
iast	18.42 s [18.42 s, 18.42 s]	3.439 s (23.0%)
iast_GLOBAL	18.278 s [18.278 s, 18.278 s]	3.297 s (22.0%)
profiling	15.361 s [15.361 s, 15.361 s]	380.0 ms (2.5%)
tracing	15.043 s [15.043 s, 15.043 s]	62.0 ms (0.4%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~67ccb2e820, baseline=1.53.0-SNAPSHOT~23cacab9e5
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1498
.   : milestone, 1487,
appsec (3.676 ms) : 3460, 3892
.   : milestone, 3676,
iast (2.215 ms) : 2152, 2277
.   : milestone, 2215,
iast_GLOBAL (2.245 ms) : 2182, 2307
.   : milestone, 2245,
profiling (2.056 ms) : 2005, 2106
.   : milestone, 2056,
tracing (2.034 ms) : 1985, 2084
.   : milestone, 2034,
section candidate
no_agent (1.479 ms) : 1468, 1491
.   : milestone, 1479,
appsec (3.612 ms) : 3399, 3826
.   : milestone, 3612,
iast (2.217 ms) : 2154, 2280
.   : milestone, 2217,
iast_GLOBAL (2.261 ms) : 2198, 2325
.   : milestone, 2261,
profiling (2.102 ms) : 2048, 2156
.   : milestone, 2102,
tracing (2.023 ms) : 1974, 2071
.   : milestone, 2023,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.487 ms [1.475 ms, 1.498 ms]	-
appsec	3.676 ms [3.46 ms, 3.892 ms]	2.189 ms (147.2%)
iast	2.215 ms [2.152 ms, 2.277 ms]	727.745 µs (48.9%)
iast_GLOBAL	2.245 ms [2.182 ms, 2.307 ms]	757.764 µs (51.0%)
profiling	2.056 ms [2.005 ms, 2.106 ms]	568.804 µs (38.3%)
tracing	2.034 ms [1.985 ms, 2.084 ms]	547.569 µs (36.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.468 ms, 1.491 ms]	-
appsec	3.612 ms [3.399 ms, 3.826 ms]	2.133 ms (144.2%)
iast	2.217 ms [2.154 ms, 2.28 ms]	737.482 µs (49.9%)
iast_GLOBAL	2.261 ms [2.198 ms, 2.325 ms]	782.252 µs (52.9%)
profiling	2.102 ms [2.048 ms, 2.156 ms]	623.181 µs (42.1%)
tracing	2.023 ms [1.974 ms, 2.071 ms]	543.713 µs (36.8%)

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#9355](DataDog/dd-trace-java#9355) - [@jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#9310](DataDog/dd-trace-java#9310) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#9294](DataDog/dd-trace-java#9294) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#9204](DataDog/dd-trace-java#9204) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#9425](DataDog/dd-trace-java#9425) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#9318](DataDog/dd-trace-java#9318) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#9278](DataDog/dd-trace-java#9278) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#9337](DataDog/dd-trace-java#9337) - [@luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#9449](DataDog/dd-trace-java#9449) - [@amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#9444](DataDog/dd-trace-java#9444) - [@amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#9442](DataDog/dd-trace-java#9442) - [@amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#9377](DataDog/dd-trace-java#9377) - [@amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#9178](DataDog/dd-trace-java#9178) - [@bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#9433](DataDog/dd-trace-java#9433) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#9401](DataDog/dd-trace-java#9401) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#9334](DataDog/dd-trace-java#9334) - [@jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#9392](DataDog/dd-trace-java#9392) - [@amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#9333](DataDog/dd-trace-java#9333) - [@amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#9323](DataDog/dd-trace-java#9323) - [@amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#9267](DataDog/dd-trace-java#9267) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#9184](DataDog/dd-trace-java#9184) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#9459](DataDog/dd-trace-java#9459) - [@ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#9299](DataDog/dd-trace-java#9299) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#9244](DataDog/dd-trace-java#9244) - [@mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#9384](DataDog/dd-trace-java#9384), [#9378](DataDog/dd-trace-java#9378), [#9358](DataDog/dd-trace-java#9358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#9289](DataDog/dd-trace-java#9289) - [@rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#9211](DataDog/dd-trace-java#9211) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#9458](DataDog/dd-trace-java#9458) - [@amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#9408](DataDog/dd-trace-java#9408) - [@amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#9387](DataDog/dd-trace-java#9387) - [@cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#9370](DataDog/dd-trace-java#9370) - [@mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#9353](DataDog/dd-trace-java#9353) - [@amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#9259](DataDog/dd-trace-java#9259) - [@mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#9367](DataDog/dd-trace-java#9367) - [@mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#9403](DataDog/dd-trace-java#9403) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#9412](DataDog/dd-trace-java#9412) - [@cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8

Avoid NPE on featureDiscovery creation

cf7d5bb

amarziali requested a review from a team as a code owner August 12, 2025 11:58

amarziali added the type: bug Bug report and fix label Aug 12, 2025

amarziali requested a review from PerfectSlayer August 12, 2025 11:58

amarziali added the comp: core Tracer core label Aug 12, 2025

mcculls reviewed Aug 12, 2025

View reviewed changes

communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java Outdated Show resolved Hide resolved

Review

67ccb2e

mcculls approved these changes Aug 12, 2025

View reviewed changes

amarziali enabled auto-merge (squash) August 12, 2025 12:11

amarziali merged commit 8d4316a into master Aug 12, 2025
500 checks passed

amarziali deleted the andrea.marziali/fix-npe branch August 12, 2025 12:52

github-actions bot added this to the 1.53.0 milestone Aug 12, 2025

amarziali mentioned this pull request Aug 12, 2025

🍒 9353 - Avoid NPE on featureDiscovery creation #9354

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid NPE on featureDiscovery creation #9353

Avoid NPE on featureDiscovery creation #9353

Uh oh!

amarziali commented Aug 12, 2025

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 12, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Aug 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Avoid NPE on featureDiscovery creation #9353

Avoid NPE on featureDiscovery creation #9353

Uh oh!

Conversation

amarziali commented Aug 12, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 12, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

datadog-datadog-prod-us1 bot commented Aug 12, 2025 •

edited

Loading