-
Couldn't load subscription status.
- Fork 315
CSS: Aggregate peer tags for consumer span kind #9442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: d64fe04 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 48 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~d64fe04818, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1047136
Total [baseline] (8.612 s) : 0, 8611571
Agent [candidate] (1.045 s) : 0, 1045214
Total [candidate] (8.627 s) : 0, 8626789
section iast
Agent [baseline] (1.179 s) : 0, 1178992
Total [baseline] (9.353 s) : 0, 9352782
Agent [candidate] (1.179 s) : 0, 1179244
Total [candidate] (9.338 s) : 0, 9338120
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~d64fe04818, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.482 ms) : 0, 1482
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (733.97 ms) : 0, 733970
BytebuddyAgent [candidate] (732.812 ms) : 0, 732812
GlobalTracer [baseline] (243.016 ms) : 0, 243016
GlobalTracer [candidate] (242.608 ms) : 0, 242608
AppSec [baseline] (30.133 ms) : 0, 30133
AppSec [candidate] (29.898 ms) : 0, 29898
Debugger [baseline] (6.094 ms) : 0, 6094
Debugger [candidate] (6.062 ms) : 0, 6062
Remote Config [baseline] (678.301 µs) : 0, 678
Remote Config [candidate] (659.984 µs) : 0, 660
Telemetry [baseline] (10.738 ms) : 0, 10738
Telemetry [candidate] (10.734 ms) : 0, 10734
section iast
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (850.907 ms) : 0, 850907
BytebuddyAgent [candidate] (851.167 ms) : 0, 851167
GlobalTracer [baseline] (233.98 ms) : 0, 233980
GlobalTracer [candidate] (234.076 ms) : 0, 234076
AppSec [baseline] (26.847 ms) : 0, 26847
AppSec [candidate] (27.736 ms) : 0, 27736
Debugger [baseline] (6.638 ms) : 0, 6638
Debugger [candidate] (5.713 ms) : 0, 5713
Remote Config [baseline] (594.778 µs) : 0, 595
Remote Config [candidate] (590.231 µs) : 0, 590
Telemetry [baseline] (8.321 ms) : 0, 8321
Telemetry [candidate] (8.33 ms) : 0, 8330
IAST [baseline] (29.295 ms) : 0, 29295
IAST [candidate] (29.138 ms) : 0, 29138
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~d64fe04818, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1046345
Total [baseline] (10.725 s) : 0, 10725217
Agent [candidate] (1.046 s) : 0, 1045964
Total [candidate] (10.737 s) : 0, 10736830
section appsec
Agent [baseline] (1.23 s) : 0, 1229667
Total [baseline] (10.757 s) : 0, 10756841
Agent [candidate] (1.22 s) : 0, 1220154
Total [candidate] (10.777 s) : 0, 10776513
section iast
Agent [baseline] (1.192 s) : 0, 1191794
Total [baseline] (11.003 s) : 0, 11002956
Agent [candidate] (1.181 s) : 0, 1181008
Total [candidate] (10.91 s) : 0, 10909503
section profiling
Agent [baseline] (1.199 s) : 0, 1199485
Total [baseline] (10.853 s) : 0, 10853077
Agent [candidate] (1.206 s) : 0, 1206124
Total [candidate] (10.875 s) : 0, 10875434
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~d64fe04818, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (732.944 ms) : 0, 732944
BytebuddyAgent [candidate] (731.036 ms) : 0, 731036
GlobalTracer [baseline] (243.229 ms) : 0, 243229
GlobalTracer [candidate] (242.634 ms) : 0, 242634
AppSec [baseline] (30.119 ms) : 0, 30119
AppSec [candidate] (30.094 ms) : 0, 30094
Debugger [baseline] (6.066 ms) : 0, 6066
Debugger [candidate] (6.067 ms) : 0, 6067
Remote Config [baseline] (666.761 µs) : 0, 667
Remote Config [candidate] (660.415 µs) : 0, 660
Telemetry [baseline] (10.743 ms) : 0, 10743
Telemetry [candidate] (12.925 ms) : 0, 12925
section appsec
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (760.227 ms) : 0, 760227
BytebuddyAgent [candidate] (753.641 ms) : 0, 753641
GlobalTracer [baseline] (236.494 ms) : 0, 236494
GlobalTracer [candidate] (234.942 ms) : 0, 234942
AppSec [baseline] (169.967 ms) : 0, 169967
AppSec [candidate] (169.989 ms) : 0, 169989
Debugger [baseline] (5.822 ms) : 0, 5822
Debugger [candidate] (6.43 ms) : 0, 6430
Remote Config [baseline] (626.292 µs) : 0, 626
Remote Config [candidate] (627.58 µs) : 0, 628
Telemetry [baseline] (10.034 ms) : 0, 10034
Telemetry [candidate] (8.421 ms) : 0, 8421
IAST [baseline] (23.79 ms) : 0, 23790
IAST [candidate] (23.546 ms) : 0, 23546
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (859.55 ms) : 0, 859550
BytebuddyAgent [candidate] (851.886 ms) : 0, 851886
GlobalTracer [baseline] (235.757 ms) : 0, 235757
GlobalTracer [candidate] (233.741 ms) : 0, 233741
AppSec [baseline] (25.656 ms) : 0, 25656
AppSec [candidate] (26.087 ms) : 0, 26087
Debugger [baseline] (9.284 ms) : 0, 9284
Debugger [candidate] (7.455 ms) : 0, 7455
Remote Config [baseline] (611.147 µs) : 0, 611
Remote Config [candidate] (594.89 µs) : 0, 595
Telemetry [baseline] (8.337 ms) : 0, 8337
Telemetry [candidate] (8.262 ms) : 0, 8262
IAST [baseline] (29.875 ms) : 0, 29875
IAST [candidate] (30.389 ms) : 0, 30389
section profiling
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (763.527 ms) : 0, 763527
BytebuddyAgent [candidate] (768.297 ms) : 0, 768297
GlobalTracer [baseline] (222.74 ms) : 0, 222740
GlobalTracer [candidate] (223.88 ms) : 0, 223880
AppSec [baseline] (30.08 ms) : 0, 30080
AppSec [candidate] (30.471 ms) : 0, 30471
Debugger [baseline] (6.315 ms) : 0, 6315
Debugger [candidate] (6.341 ms) : 0, 6341
Remote Config [baseline] (710.067 µs) : 0, 710
Remote Config [candidate] (696.965 µs) : 0, 697
Telemetry [baseline] (16.384 ms) : 0, 16384
Telemetry [candidate] (16.229 ms) : 0, 16229
ProfilingAgent [baseline] (107.767 ms) : 0, 107767
ProfilingAgent [candidate] (107.921 ms) : 0, 107921
Profiling [baseline] (108.409 ms) : 0, 108409
Profiling [candidate] (108.594 ms) : 0, 108594
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d64fe04818, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section baseline
no_agent (4.425 ms) : 4367, 4483
. : milestone, 4425,
iast (9.569 ms) : 9409, 9729
. : milestone, 9569,
iast_FULL (14.935 ms) : 14628, 15243
. : milestone, 14935,
iast_GLOBAL (10.192 ms) : 10012, 10371
. : milestone, 10192,
profiling (8.857 ms) : 8713, 9001
. : milestone, 8857,
tracing (7.4 ms) : 7298, 7503
. : milestone, 7400,
section candidate
no_agent (4.363 ms) : 4310, 4416
. : milestone, 4363,
iast (9.301 ms) : 9149, 9452
. : milestone, 9301,
iast_FULL (13.878 ms) : 13604, 14153
. : milestone, 13878,
iast_GLOBAL (10.479 ms) : 10292, 10667
. : milestone, 10479,
profiling (8.65 ms) : 8506, 8795
. : milestone, 8650,
tracing (7.608 ms) : 7493, 7722
. : milestone, 7608,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~d64fe04818, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section baseline
no_agent (36.598 ms) : 36302, 36894
. : milestone, 36598,
appsec (47.741 ms) : 47316, 48165
. : milestone, 47741,
code_origins (45.63 ms) : 45241, 46018
. : milestone, 45630,
iast (45.099 ms) : 44715, 45483
. : milestone, 45099,
profiling (47.404 ms) : 46972, 47835
. : milestone, 47404,
tracing (46.729 ms) : 46316, 47142
. : milestone, 46729,
section candidate
no_agent (36.803 ms) : 36501, 37105
. : milestone, 36803,
appsec (48.072 ms) : 47659, 48486
. : milestone, 48072,
code_origins (45.867 ms) : 45451, 46283
. : milestone, 45867,
iast (43.714 ms) : 43343, 44085
. : milestone, 43714,
profiling (47.975 ms) : 47545, 48405
. : milestone, 47975,
tracing (43.462 ms) : 43106, 43818
. : milestone, 43462,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d64fe04818, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.655 ms) : 3437, 3872
. : milestone, 3655,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.251 ms) : 2188, 2314
. : milestone, 2251,
profiling (2.074 ms) : 2021, 2127
. : milestone, 2074,
tracing (2.036 ms) : 1986, 2086
. : milestone, 2036,
section candidate
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.667 ms) : 3450, 3885
. : milestone, 3667,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.251 ms) : 2187, 2314
. : milestone, 2251,
profiling (2.038 ms) : 1988, 2089
. : milestone, 2038,
tracing (2.021 ms) : 1972, 2070
. : milestone, 2021,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~d64fe04818, baseline=1.53.0-SNAPSHOT~d43410737f
dateFormat X
axisFormat %s
section baseline
no_agent (15.606 s) : 15606000, 15606000
. : milestone, 15606000,
appsec (15.011 s) : 15011000, 15011000
. : milestone, 15011000,
iast (18.312 s) : 18312000, 18312000
. : milestone, 18312000,
iast_GLOBAL (18.101 s) : 18101000, 18101000
. : milestone, 18101000,
profiling (15.479 s) : 15479000, 15479000
. : milestone, 15479000,
tracing (15.188 s) : 15188000, 15188000
. : milestone, 15188000,
section candidate
no_agent (15.338 s) : 15338000, 15338000
. : milestone, 15338000,
appsec (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
iast (18.425 s) : 18425000, 18425000
. : milestone, 18425000,
iast_GLOBAL (18.098 s) : 18098000, 18098000
. : milestone, 18098000,
profiling (15.815 s) : 15815000, 15815000
. : milestone, 15815000,
tracing (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
|
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#​9355](DataDog/dd-trace-java#9355) - [@​jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#​9310](DataDog/dd-trace-java#9310) - [@​jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#​9294](DataDog/dd-trace-java#9294) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#​9204](DataDog/dd-trace-java#9204) - [@​sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#​9425](DataDog/dd-trace-java#9425) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#​9318](DataDog/dd-trace-java#9318) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#​9278](DataDog/dd-trace-java#9278) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#​9337](DataDog/dd-trace-java#9337) - [@​luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#​9449](DataDog/dd-trace-java#9449) - [@​amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#​9444](DataDog/dd-trace-java#9444) - [@​amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#​9442](DataDog/dd-trace-java#9442) - [@​amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#​9377](DataDog/dd-trace-java#9377) - [@​amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#​9178](DataDog/dd-trace-java#9178) - [@​bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#​9433](DataDog/dd-trace-java#9433) - [@​MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#​9401](DataDog/dd-trace-java#9401) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#​9334](DataDog/dd-trace-java#9334) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#​9392](DataDog/dd-trace-java#9392) - [@​amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#​9333](DataDog/dd-trace-java#9333) - [@​amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#​9323](DataDog/dd-trace-java#9323) - [@​amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#​9267](DataDog/dd-trace-java#9267) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#​9184](DataDog/dd-trace-java#9184) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#​9459](DataDog/dd-trace-java#9459) - [@​ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#​9299](DataDog/dd-trace-java#9299) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#​9244](DataDog/dd-trace-java#9244) - [@​mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#​9384](DataDog/dd-trace-java#9384), [#​9378](DataDog/dd-trace-java#9378), [#​9358](DataDog/dd-trace-java#9358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#​9289](DataDog/dd-trace-java#9289) - [@​rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#​9211](DataDog/dd-trace-java#9211) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#​9458](DataDog/dd-trace-java#9458) - [@​amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#​9408](DataDog/dd-trace-java#9408) - [@​amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#​9387](DataDog/dd-trace-java#9387) - [@​cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#​9370](DataDog/dd-trace-java#9370) - [@​mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#​9353](DataDog/dd-trace-java#9353) - [@​amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#​9259](DataDog/dd-trace-java#9259) - [@​mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#​9367](DataDog/dd-trace-java#9367) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#​9403](DataDog/dd-trace-java#9403) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#​9412](DataDog/dd-trace-java#9412) - [@​cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8
What Does This Do
consumerspan kind should also have peer tags aggregated. This is mostly important for_dd.base_serviceMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]