Avoid multiple injections on dispatch on jboss #9392

amarziali · 2025-08-20T13:45:32Z

What Does This Do

Avoids wrapping multiple time the response when rum injection is enabled. This will lead to multiple injections in some cases. This is due to the fact that the class injected as helper used to wrap the response is stored on a single request. However, because of the jboss classloading, the same helper might be injected several time and the instanceof conditions were not working as expected.

I added a specific smoke test for wildfly-15. Also, all the rum smoke tests are now checking for injecting only once

Please note that async servlet 3 on jboss is not injecting. This need to be fixed separately on another PR part of a larger effort.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-datadog-prod-us1 · 2025-08-20T13:59:21Z

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 57.56% (-0.01%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 65a8c19 | Docs | Was this helpful? Give us feedback!}

github-actions · 2025-08-20T14:03:25Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

pr-commenter · 2025-08-20T14:45:36Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/rum-jboss-fix
git_commit_date	1755723343	1755763207
git_commit_sha	`5aa25ba`	`65a8c19`
release_version	1.53.0-SNAPSHOT~5aa25baa32	1.53.0-SNAPSHOT~65a8c19669

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755765003	1755765003
ci_job_id	1091344268	1091344268
ci_pipeline_id	74338338	74338338
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-tf0ju9tw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-tf0ju9tw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 15 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~65a8c19669, baseline=1.53.0-SNAPSHOT~5aa25baa32

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045023
Total [baseline] (10.622 s) : 0, 10622164
Agent [candidate] (1.049 s) : 0, 1049213
Total [candidate] (10.689 s) : 0, 10689473
section appsec
Agent [baseline] (1.22 s) : 0, 1219987
Total [baseline] (10.776 s) : 0, 10776394
Agent [candidate] (1.226 s) : 0, 1226086
Total [candidate] (10.776 s) : 0, 10775983
section iast
Agent [baseline] (1.193 s) : 0, 1193334
Total [baseline] (10.951 s) : 0, 10951114
Agent [candidate] (1.181 s) : 0, 1181492
Total [candidate] (10.91 s) : 0, 10910385
section profiling
Agent [baseline] (1.195 s) : 0, 1195422
Total [baseline] (10.892 s) : 0, 10892432
Agent [candidate] (1.198 s) : 0, 1198414
Total [candidate] (10.867 s) : 0, 10867240

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	appsec	1.22 s	174.964 ms (16.7%)
Agent	iast	1.193 s	148.311 ms (14.2%)
Agent	profiling	1.195 s	150.4 ms (14.4%)
Total	tracing	10.622 s	-
Total	appsec	10.776 s	154.23 ms (1.5%)
Total	iast	10.951 s	328.95 ms (3.1%)
Total	profiling	10.892 s	270.267 ms (2.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.049 s	-
Agent	appsec	1.226 s	176.873 ms (16.9%)
Agent	iast	1.181 s	132.279 ms (12.6%)
Agent	profiling	1.198 s	149.2 ms (14.2%)
Total	tracing	10.689 s	-
Total	appsec	10.776 s	86.51 ms (0.8%)
Total	iast	10.91 s	220.912 ms (2.1%)
Total	profiling	10.867 s	177.767 ms (1.7%)

gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~65a8c19669, baseline=1.53.0-SNAPSHOT~5aa25baa32

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (731.986 ms) : 0, 731986
BytebuddyAgent [candidate] (733.573 ms) : 0, 733573
GlobalTracer [baseline] (242.05 ms) : 0, 242050
GlobalTracer [candidate] (243.043 ms) : 0, 243043
AppSec [baseline] (30.068 ms) : 0, 30068
AppSec [candidate] (30.197 ms) : 0, 30197
Debugger [baseline] (6.07 ms) : 0, 6070
Debugger [candidate] (6.105 ms) : 0, 6105
Remote Config [baseline] (672.149 µs) : 0, 672
Remote Config [candidate] (666.381 µs) : 0, 666
Telemetry [baseline] (11.591 ms) : 0, 11591
Telemetry [candidate] (12.983 ms) : 0, 12983
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (752.912 ms) : 0, 752912
BytebuddyAgent [candidate] (756.81 ms) : 0, 756810
GlobalTracer [baseline] (234.879 ms) : 0, 234879
GlobalTracer [candidate] (236.102 ms) : 0, 236102
AppSec [baseline] (170.493 ms) : 0, 170493
AppSec [candidate] (168.05 ms) : 0, 168050
Debugger [baseline] (6.512 ms) : 0, 6512
Debugger [candidate] (8.084 ms) : 0, 8084
Remote Config [baseline] (644.621 µs) : 0, 645
Remote Config [candidate] (651.915 µs) : 0, 652
Telemetry [baseline] (8.411 ms) : 0, 8411
Telemetry [candidate] (10.115 ms) : 0, 10115
IAST [baseline] (23.601 ms) : 0, 23601
IAST [candidate] (23.568 ms) : 0, 23568
section iast
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (863.774 ms) : 0, 863774
BytebuddyAgent [candidate] (852.594 ms) : 0, 852594
GlobalTracer [baseline] (233.68 ms) : 0, 233680
GlobalTracer [candidate] (233.557 ms) : 0, 233557
AppSec [baseline] (27.791 ms) : 0, 27791
AppSec [candidate] (29.387 ms) : 0, 29387
Debugger [baseline] (7.475 ms) : 0, 7475
Debugger [candidate] (5.808 ms) : 0, 5808
Remote Config [baseline] (616.131 µs) : 0, 616
Remote Config [candidate] (605.44 µs) : 0, 605
Telemetry [baseline] (8.426 ms) : 0, 8426
Telemetry [candidate] (8.322 ms) : 0, 8322
IAST [baseline] (28.813 ms) : 0, 28813
IAST [candidate] (28.494 ms) : 0, 28494
section profiling
crashtracking [baseline] (1.41 ms) : 0, 1410
crashtracking [candidate] (1.429 ms) : 0, 1429
BytebuddyAgent [baseline] (760.876 ms) : 0, 760876
BytebuddyAgent [candidate] (763.096 ms) : 0, 763096
GlobalTracer [baseline] (221.929 ms) : 0, 221929
GlobalTracer [candidate] (222.359 ms) : 0, 222359
AppSec [baseline] (30.018 ms) : 0, 30018
AppSec [candidate] (30.916 ms) : 0, 30916
Debugger [baseline] (7.039 ms) : 0, 7039
Debugger [candidate] (6.322 ms) : 0, 6322
Remote Config [baseline] (715.493 µs) : 0, 715
Remote Config [candidate] (703.447 µs) : 0, 703
Telemetry [baseline] (15.767 ms) : 0, 15767
Telemetry [candidate] (15.435 ms) : 0, 15435
ProfilingAgent [baseline] (108.019 ms) : 0, 108019
ProfilingAgent [candidate] (108.327 ms) : 0, 108327
Profiling [baseline] (108.676 ms) : 0, 108676
Profiling [candidate] (108.994 ms) : 0, 108994

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~65a8c19669, baseline=1.53.0-SNAPSHOT~5aa25baa32

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1053225
Total [baseline] (8.621 s) : 0, 8621039
Agent [candidate] (1.047 s) : 0, 1047371
Total [candidate] (8.655 s) : 0, 8654921
section iast
Agent [baseline] (1.186 s) : 0, 1185735
Total [baseline] (9.347 s) : 0, 9346959
Agent [candidate] (1.187 s) : 0, 1186873
Total [candidate] (9.368 s) : 0, 9367993

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.053 s	-
Agent	iast	1.186 s	132.509 ms (12.6%)
Total	tracing	8.621 s	-
Total	iast	9.347 s	725.92 ms (8.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	iast	1.187 s	139.502 ms (13.3%)
Total	tracing	8.655 s	-
Total	iast	9.368 s	713.072 ms (8.2%)

gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~65a8c19669, baseline=1.53.0-SNAPSHOT~5aa25baa32

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.471 ms) : 0, 1471
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (738.281 ms) : 0, 738281
BytebuddyAgent [candidate] (732.049 ms) : 0, 732049
GlobalTracer [baseline] (244.3 ms) : 0, 244300
GlobalTracer [candidate] (242.425 ms) : 0, 242425
AppSec [baseline] (30.377 ms) : 0, 30377
AppSec [candidate] (30.094 ms) : 0, 30094
Debugger [baseline] (6.085 ms) : 0, 6085
Debugger [candidate] (6.058 ms) : 0, 6058
Remote Config [baseline] (673.891 µs) : 0, 674
Remote Config [candidate] (671.5 µs) : 0, 672
Telemetry [baseline] (10.935 ms) : 0, 10935
Telemetry [candidate] (13.684 ms) : 0, 13684
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (856.892 ms) : 0, 856892
BytebuddyAgent [candidate] (856.758 ms) : 0, 856758
GlobalTracer [baseline] (234.19 ms) : 0, 234190
GlobalTracer [candidate] (234.141 ms) : 0, 234141
AppSec [baseline] (26.897 ms) : 0, 26897
AppSec [candidate] (28.03 ms) : 0, 28030
Debugger [baseline] (6.73 ms) : 0, 6730
Debugger [candidate] (7.546 ms) : 0, 7546
Remote Config [baseline] (633.611 µs) : 0, 634
Remote Config [candidate] (612.068 µs) : 0, 612
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (8.374 ms) : 0, 8374
IAST [baseline] (29.441 ms) : 0, 29441
IAST [candidate] (28.841 ms) : 0, 28841

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/rum-jboss-fix
git_commit_date	1755723343	1755763207
git_commit_sha	`5aa25ba`	`65a8c19`
release_version	1.53.0-SNAPSHOT~5aa25baa32	1.53.0-SNAPSHOT~65a8c19669

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1755764679	1755764679
ci_job_id	1091344269	1091344269
ci_pipeline_id	74338338	74338338
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-adiapppq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-adiapppq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:profiling:high_load	worse [+175.355µs; +469.628µs] or [+2.010%; +5.382%]	unstable [-81.081op/s; +43.768op/s] or [-15.253%; +8.234%]	9.049ms	512.906op/s	8.726ms	531.562op/s
scenario:load:petclinic:profiling:high_load	worse [+1.115ms; +2.143ms] or [+2.289%; +4.401%]	unstable [-10.321op/s; +4.096op/s] or [-10.737%; +4.261%]	50.324ms	93.013op/s	48.695ms	96.125op/s
scenario:load:petclinic:no_agent:high_load	better [-2.257ms; -1.626ms] or [-5.956%; -4.291%]	unstable [-2.533op/s; +15.683op/s] or [-2.053%; +12.707%]	35.956ms	130.000op/s	37.897ms	123.425op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~65a8c19669, baseline=1.53.0-SNAPSHOT~5aa25baa32
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.897 ms) : 37598, 38197
.   : milestone, 37897,
appsec (46.642 ms) : 46234, 47050
.   : milestone, 46642,
code_origins (45.483 ms) : 45069, 45898
.   : milestone, 45483,
iast (44.648 ms) : 44255, 45042
.   : milestone, 44648,
profiling (48.695 ms) : 48202, 49188
.   : milestone, 48695,
tracing (44.365 ms) : 43987, 44743
.   : milestone, 44365,
section candidate
no_agent (35.956 ms) : 35669, 36242
.   : milestone, 35956,
appsec (46.873 ms) : 46438, 47309
.   : milestone, 46873,
code_origins (45.906 ms) : 45506, 46306
.   : milestone, 45906,
iast (44.059 ms) : 43671, 44447
.   : milestone, 44059,
profiling (50.324 ms) : 49862, 50786
.   : milestone, 50324,
tracing (45.16 ms) : 44776, 45545
.   : milestone, 45160,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.897 ms [37.598 ms, 38.197 ms]	-
appsec	46.642 ms [46.234 ms, 47.05 ms]	8.745 ms (23.1%)
code_origins	45.483 ms [45.069 ms, 45.898 ms]	7.586 ms (20.0%)
iast	44.648 ms [44.255 ms, 45.042 ms]	6.751 ms (17.8%)
profiling	48.695 ms [48.202 ms, 49.188 ms]	10.798 ms (28.5%)
tracing	44.365 ms [43.987 ms, 44.743 ms]	6.467 ms (17.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	35.956 ms [35.669 ms, 36.242 ms]	-
appsec	46.873 ms [46.438 ms, 47.309 ms]	10.918 ms (30.4%)
code_origins	45.906 ms [45.506 ms, 46.306 ms]	9.95 ms (27.7%)
iast	44.059 ms [43.671 ms, 44.447 ms]	8.104 ms (22.5%)
profiling	50.324 ms [49.862 ms, 50.786 ms]	14.368 ms (40.0%)
tracing	45.16 ms [44.776 ms, 45.545 ms]	9.205 ms (25.6%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~65a8c19669, baseline=1.53.0-SNAPSHOT~5aa25baa32
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.366 ms) : 4316, 4415
.   : milestone, 4366,
iast (9.378 ms) : 9211, 9545
.   : milestone, 9378,
iast_FULL (13.808 ms) : 13531, 14085
.   : milestone, 13808,
iast_GLOBAL (10.252 ms) : 10072, 10432
.   : milestone, 10252,
profiling (8.726 ms) : 8596, 8857
.   : milestone, 8726,
tracing (7.589 ms) : 7467, 7710
.   : milestone, 7589,
section candidate
no_agent (4.286 ms) : 4239, 4333
.   : milestone, 4286,
iast (9.311 ms) : 9152, 9469
.   : milestone, 9311,
iast_FULL (13.435 ms) : 13167, 13704
.   : milestone, 13435,
iast_GLOBAL (10.117 ms) : 9926, 10307
.   : milestone, 10117,
profiling (9.049 ms) : 8906, 9191
.   : milestone, 9049,
tracing (7.685 ms) : 7568, 7802
.   : milestone, 7685,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.366 ms [4.316 ms, 4.415 ms]	-
iast	9.378 ms [9.211 ms, 9.545 ms]	5.012 ms (114.8%)
iast_FULL	13.808 ms [13.531 ms, 14.085 ms]	9.443 ms (216.3%)
iast_GLOBAL	10.252 ms [10.072 ms, 10.432 ms]	5.886 ms (134.8%)
profiling	8.726 ms [8.596 ms, 8.857 ms]	4.361 ms (99.9%)
tracing	7.589 ms [7.467 ms, 7.71 ms]	3.223 ms (73.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.286 ms [4.239 ms, 4.333 ms]	-
iast	9.311 ms [9.152 ms, 9.469 ms]	5.025 ms (117.2%)
iast_FULL	13.435 ms [13.167 ms, 13.704 ms]	9.149 ms (213.5%)
iast_GLOBAL	10.117 ms [9.926 ms, 10.307 ms]	5.831 ms (136.0%)
profiling	9.049 ms [8.906 ms, 9.191 ms]	4.763 ms (111.1%)
tracing	7.685 ms [7.568 ms, 7.802 ms]	3.399 ms (79.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/rum-jboss-fix
git_commit_date	1755723343	1755763207
git_commit_sha	`5aa25ba`	`65a8c19`
release_version	1.53.0-SNAPSHOT~5aa25baa32	1.53.0-SNAPSHOT~65a8c19669

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1755765223	1755765223
ci_job_id	1091344272	1091344272
ci_pipeline_id	74338338	74338338
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-miql2bep 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-miql2bep 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~65a8c19669, baseline=1.53.0-SNAPSHOT~5aa25baa32
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.507 s) : 15507000, 15507000
.   : milestone, 15507000,
appsec (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,
iast (18.6 s) : 18600000, 18600000
.   : milestone, 18600000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
.   : milestone, 18113000,
profiling (15.323 s) : 15323000, 15323000
.   : milestone, 15323000,
tracing (14.933 s) : 14933000, 14933000
.   : milestone, 14933000,
section candidate
no_agent (14.836 s) : 14836000, 14836000
.   : milestone, 14836000,
appsec (15.099 s) : 15099000, 15099000
.   : milestone, 15099000,
iast (18.126 s) : 18126000, 18126000
.   : milestone, 18126000,
iast_GLOBAL (18.324 s) : 18324000, 18324000
.   : milestone, 18324000,
profiling (15.448 s) : 15448000, 15448000
.   : milestone, 15448000,
tracing (15.134 s) : 15134000, 15134000
.   : milestone, 15134000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.507 s [15.507 s, 15.507 s]	-
appsec	15.01 s [15.01 s, 15.01 s]	-497.0 ms (-3.2%)
iast	18.6 s [18.6 s, 18.6 s]	3.093 s (19.9%)
iast_GLOBAL	18.113 s [18.113 s, 18.113 s]	2.606 s (16.8%)
profiling	15.323 s [15.323 s, 15.323 s]	-184.0 ms (-1.2%)
tracing	14.933 s [14.933 s, 14.933 s]	-574.0 ms (-3.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.836 s [14.836 s, 14.836 s]	-
appsec	15.099 s [15.099 s, 15.099 s]	263.0 ms (1.8%)
iast	18.126 s [18.126 s, 18.126 s]	3.29 s (22.2%)
iast_GLOBAL	18.324 s [18.324 s, 18.324 s]	3.488 s (23.5%)
profiling	15.448 s [15.448 s, 15.448 s]	612.0 ms (4.1%)
tracing	15.134 s [15.134 s, 15.134 s]	298.0 ms (2.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~65a8c19669, baseline=1.53.0-SNAPSHOT~5aa25baa32
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (3.631 ms) : 3413, 3848
.   : milestone, 3631,
iast (2.2 ms) : 2137, 2262
.   : milestone, 2200,
iast_GLOBAL (2.251 ms) : 2188, 2315
.   : milestone, 2251,
profiling (2.044 ms) : 1993, 2094
.   : milestone, 2044,
tracing (2.022 ms) : 1973, 2072
.   : milestone, 2022,
section candidate
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (3.662 ms) : 3444, 3879
.   : milestone, 3662,
iast (2.205 ms) : 2142, 2268
.   : milestone, 2205,
iast_GLOBAL (2.243 ms) : 2180, 2306
.   : milestone, 2243,
profiling (2.071 ms) : 2019, 2123
.   : milestone, 2071,
tracing (2.019 ms) : 1971, 2068
.   : milestone, 2019,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.467 ms, 1.49 ms]	-
appsec	3.631 ms [3.413 ms, 3.848 ms]	2.152 ms (145.6%)
iast	2.2 ms [2.137 ms, 2.262 ms]	721.149 µs (48.8%)
iast_GLOBAL	2.251 ms [2.188 ms, 2.315 ms]	772.818 µs (52.3%)
profiling	2.044 ms [1.993 ms, 2.094 ms]	565.206 µs (38.2%)
tracing	2.022 ms [1.973 ms, 2.072 ms]	543.833 µs (36.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	3.662 ms [3.444 ms, 3.879 ms]	2.186 ms (148.1%)
iast	2.205 ms [2.142 ms, 2.268 ms]	729.587 µs (49.4%)
iast_GLOBAL	2.243 ms [2.18 ms, 2.306 ms]	767.304 µs (52.0%)
profiling	2.071 ms [2.019 ms, 2.123 ms]	595.017 µs (40.3%)
tracing	2.019 ms [1.971 ms, 2.068 ms]	543.545 µs (36.8%)

PerfectSlayer

Looks good from the instrumentation fix part 👍
The Jboss EAR / WAR setup is a bit fuzzy to me.
Feel free to have another pair of eyes if you need it 👀

PerfectSlayer · 2025-08-21T08:07:22Z

dd-smoke-tests/rum/wildfly-15/src/test/groovy/datadog/smoketest/Wildfly15RumSmokeTest.groovy

+  def setupSpec() {
+    //wait for the deployment
+    new PollingConditions(timeout: 300, delay: 2).eventually {
+      assert OkHttpUtils.client().newCall(new Request.Builder().url("http://localhost:$httpPort/war/html").build()).execute().code() == 200


🎯 suggestion: ‏

Suggested change

assert OkHttpUtils.client().newCall(new Request.Builder().url("http://localhost:$httpPort/war/html").build()).execute().code() == 200

assert OkHttpUtils.client().newCall(new Request.Builder().url("http://localhost:$httpPort${mountPoint()}/html").build()).execute().code() == 200

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#9355](DataDog/dd-trace-java#9355) - [@jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#9310](DataDog/dd-trace-java#9310) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#9294](DataDog/dd-trace-java#9294) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#9204](DataDog/dd-trace-java#9204) - [@sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#9425](DataDog/dd-trace-java#9425) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#9318](DataDog/dd-trace-java#9318) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#9278](DataDog/dd-trace-java#9278) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#9282](DataDog/dd-trace-java#9282) - [@ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#9337](DataDog/dd-trace-java#9337) - [@luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#9449](DataDog/dd-trace-java#9449) - [@amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#9444](DataDog/dd-trace-java#9444) - [@amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#9442](DataDog/dd-trace-java#9442) - [@amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#9377](DataDog/dd-trace-java#9377) - [@amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#9178](DataDog/dd-trace-java#9178) - [@bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#9433](DataDog/dd-trace-java#9433) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#9401](DataDog/dd-trace-java#9401) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#9334](DataDog/dd-trace-java#9334) - [@jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#9392](DataDog/dd-trace-java#9392) - [@amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#9333](DataDog/dd-trace-java#9333) - [@amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#9323](DataDog/dd-trace-java#9323) - [@amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#9267](DataDog/dd-trace-java#9267) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#9184](DataDog/dd-trace-java#9184) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#9459](DataDog/dd-trace-java#9459) - [@ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#9299](DataDog/dd-trace-java#9299) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#9244](DataDog/dd-trace-java#9244) - [@mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#9384](DataDog/dd-trace-java#9384), [#9378](DataDog/dd-trace-java#9378), [#9358](DataDog/dd-trace-java#9358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#9289](DataDog/dd-trace-java#9289) - [@rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#9211](DataDog/dd-trace-java#9211) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#9458](DataDog/dd-trace-java#9458) - [@amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#9408](DataDog/dd-trace-java#9408) - [@amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#9387](DataDog/dd-trace-java#9387) - [@cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#9370](DataDog/dd-trace-java#9370) - [@mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#9353](DataDog/dd-trace-java#9353) - [@amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#9259](DataDog/dd-trace-java#9259) - [@mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#9367](DataDog/dd-trace-java#9367) - [@mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#9321](DataDog/dd-trace-java#9321) - [@na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#9403](DataDog/dd-trace-java#9403) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#9412](DataDog/dd-trace-java#9412) - [@cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8

amarziali requested review from a team as code owners August 20, 2025 13:45

amarziali requested review from PerfectSlayer, dougqh and mcculls August 20, 2025 13:45

amarziali added the type: bug Bug report and fix label Aug 20, 2025

amarziali force-pushed the andrea.marziali/rum-jboss-fix branch from dad0c41 to 50f7cca Compare August 20, 2025 14:03

amarziali added the comp: rum Realtime User Monitoring label Aug 20, 2025

Avoid multiple injections on dispatch on jboss

1b1a350

amarziali force-pushed the andrea.marziali/rum-jboss-fix branch from 50f7cca to 1b1a350 Compare August 20, 2025 14:10

Merge branch 'master' into andrea.marziali/rum-jboss-fix

65a8c19

PerfectSlayer approved these changes Aug 21, 2025

View reviewed changes

amarziali merged commit 47394fd into master Aug 22, 2025
670 of 671 checks passed

amarziali deleted the andrea.marziali/rum-jboss-fix branch August 22, 2025 10:30

github-actions bot added this to the 1.53.0 milestone Aug 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid multiple injections on dispatch on jboss #9392

Avoid multiple injections on dispatch on jboss #9392

Uh oh!

amarziali commented Aug 20, 2025 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 20, 2025 •

edited by datadog-official bot

Loading

Uh oh!

github-actions bot commented Aug 20, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Aug 20, 2025 •

edited

Loading

Uh oh!

PerfectSlayer left a comment

Uh oh!

PerfectSlayer Aug 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	assert OkHttpUtils.client().newCall(new Request.Builder().url("http://localhost:$httpPort/war/html").build()).execute().code() == 200
	assert OkHttpUtils.client().newCall(new Request.Builder().url("http://localhost:$httpPort${mountPoint()}/html").build()).execute().code() == 200

Avoid multiple injections on dispatch on jboss #9392

Avoid multiple injections on dispatch on jboss #9392

Uh oh!

Conversation

amarziali commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-datadog-prod-us1 bot commented Aug 20, 2025 • edited by datadog-official bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Aug 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amarziali commented Aug 20, 2025 •

edited

Loading

datadog-datadog-prod-us1 bot commented Aug 20, 2025 •

edited by datadog-official bot

Loading

github-actions bot commented Aug 20, 2025 •

edited

Loading

pr-commenter bot commented Aug 20, 2025 •

edited

Loading