Skip to content

Conversation

@garrettwrong
Copy link
Collaborator

Need to run some local tests first, but we're almost ready to release.

First draft of notes below:

ASPIRE v0.10.0 is large release adding a wide range of features and fixes.

This release provides the following features:

  • Common Lines Method for C3/C4 Symmetry (CLSymmetryC3C4, experimental)
  • Image Accessor API for ImageSource
  • Parallelized BFSReddyChatterjiAverager2D and ReddyChatterjiAverager2D class averaging image aligners
  • Support Nonsequential ImageSource.images
  • Improved RIRClass2D batching
  • crop_pad_3d
  • Replace 2D Downsample algorithm (includes 1-pixel scaling bugfix)
  • ClassSelector API and RandomClassSelector (now randomized as default)
  • gaussian_* helper functions
  • Filter.sign method
  • Integrate CTF estimator with CoordinateSource

Bug fixes:

  • Improved dtype passthrough
  • Volume.flip default axis change
  • Rectangular micrograph axes
  • Fix crash in BatchedRotCov2D when invoked without CTF details
  • Volume.dtype mismatches and checks

Systems/CI Updates:

  • Refresh Azure pipeline Ubuntu images
  • Deprecate Azure OSX 10.15 CI in favor of OSX 11

Cleanup and Documentation Updates:

  • Logical (F)FBBasis3D tests
  • Documentation format cleanup (fixes broken parsing)
  • Top level submodule imports (API improvement)
  • .rots ~> .rotations attribute cleanup
  • 3D Downsampling cleanup
  • Improved Getting Started page
  • Improved Gallery Tutorials and Experiments examples
  • Sphinx language patch
  • Implement lower bound checks for FSPCA components
  • Fourier-Bessel Mixin class (FBBasisMixin)
  • Resolve PIL package deprecations
  • Update ComplexPCA scikit workaround for upstream releases
  • Improve evaluate and evaluate_t API standards
  • Improve Zenodo affiliation integration

Very proud of the progress we've made, and thanks for your efforts!

j-c-c and others added 30 commits June 28, 2022 12:06
Fix `bad_applepick.star` after running Apple test
Update latest flake8 bugbear finds re B023 in lambda functions
Refactor `ainner` to handle complex values
…allow for scalar valued sigma, update all uses.
* fix metadata bug

* put space back in

* format
j-c-c and others added 20 commits October 5, 2022 12:11
Sphinx 5 expects a language defined
* added ImageAccessor class

* images to property

* RelionSource _images() change

* keys can be slice list or numpy array

* added key tests

* first round of sed replacements

* second round

* small fixes

* initial Simulation changes

* max num check and ArrayImageSource _images()

* formatting

* type check and coordinate source _images

* format

* images_super

* small fixes

* clean images fix

* projections and clean_images

* tests fixes

* docstrings

* abc and docstring changes

* orient estimation source _images

* start:stop:step

* test fixes

* add range and filter

* projections docstring

* refactor _images

* iterables

* comment

* iterable check

* clean images docstring

* docstrings

* cleanup docstrings

* bad key check

* review fixes

* indexing fixes

* extra tests

* negative indices

* negative indices

* test caching in lower level _images methods

* private class ImageAccessor and remove from source.__init__

* extra checks for slice and out of range indices

* rename variable for cleaner diff

* geq

* clean up relion source cache check

Co-authored-by: Garrett Wright <[email protected]>
@chris-langfield
Copy link
Collaborator

Notes look good to me! 🥳

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #731 (0bd790b) into master (1bff8d3) will increase coverage by 1.54%.
The diff coverage is 94.55%.

@@            Coverage Diff             @@
##           master     #731      +/-   ##
==========================================
+ Coverage   86.49%   88.04%   +1.54%     
==========================================
  Files         109      114       +5     
  Lines        8286     8797     +511     
==========================================
+ Hits         7167     7745     +578     
+ Misses       1119     1052      -67     
Impacted Files Coverage Δ
src/aspire/apple/apple.py 61.53% <ø> (ø)
src/aspire/apple/helper.py 100.00% <ø> (ø)
src/aspire/basis/__init__.py 100.00% <ø> (ø)
src/aspire/basis/basis_utils.py 98.17% <ø> (ø)
src/aspire/basis/fpswf_2d.py 97.40% <ø> (-1.30%) ⬇️
src/aspire/commands/preprocess.py 0.00% <0.00%> (ø)
src/aspire/image/preprocess.py 37.20% <ø> (-19.77%) ⬇️
src/aspire/image/xform.py 72.72% <ø> (ø)
src/aspire/nufft/finufft.py 100.00% <ø> (ø)
src/aspire/operators/blk_diag_matrix.py 95.72% <ø> (ø)
... and 61 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@garrettwrong
Copy link
Collaborator Author

Ran pytest for pip package against Python 3.7, 3.8, 3.9, 3.10. Docs and gallery built. Ran simulated pipeline experiment.

Should be good to move forward with the merge, tag, and push to PyPI.

@garrettwrong garrettwrong merged commit d08a9f7 into master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants