Update latest flake8 bugbear finds re B023 in lambda functions #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #653 +/- ##
========================================
Coverage 86.50% 86.50%
========================================
Files 109 109
Lines 8293 8293
========================================
Hits 7174 7174
Misses 1119 1119
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Collaborator
Author
|
@chris-langfield , any concerns with this? I'd like to merge it in. We can skip Joakim on it if you have time to check it... Thanks |
chris-langfield
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently this is what they are concerned about...
https://docs.python-guide.org/writing/gotchas/#late-binding-closures
Hopefully after the patch we still pass pytest 😅 .