Skip to content

Numpy to Volume in evaluate_t #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

Numpy to Volume in evaluate_t #711

merged 1 commit into from
Oct 5, 2022

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Oct 5, 2022

Missed one occurrence of passing NumPy array to sevaluate_t() in #709. This will close #701.

@garrettwrong garrettwrong self-requested a review October 5, 2022 14:20
garrettwrong
garrettwrong approved these changes Oct 5, 2022
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, this was same way I fixed it locally. Once the unit test pass we can force merge it (ie we can skip Joakim on this one).

Thanks!

@codecov
Copy link

codecov bot commented Oct 5, 2022 •
edited
Loading

Codecov Report

Merging #711 (f2f3baa) into develop (7bbcf51) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #711      +/-   ##
===========================================
- Coverage    87.94%   87.87%   -0.07%     
===========================================
  Files          114      114              
  Lines         8760     8760              
===========================================
- Hits          7704     7698       -6     
- Misses        1056     1062       +6
Impacted Files Coverage Δ
src/aspire/reconstruction/estimator.py 92.40% <100.00%> (ø)
src/aspire/basis/basis.py 81.81% <0.00%> (-6.50%) ⬇️
src/aspire/source/coordinates.py 91.41% <0.00%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@j-c-c j-c-c marked this pull request as ready for review October 5, 2022 16:09
@j-c-c j-c-c requested a review from janden as a code owner October 5, 2022 16:09
@j-c-c j-c-c merged commit 3022a37 into develop Oct 5, 2022
@j-c-c j-c-c deleted the estimator_numpy_to_vol_701 branch October 5, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettwrong garrettwrong garrettwrong approved these changes

@janden janden Awaiting requested review from janden janden is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-c-c @garrettwrong