Skip to content

evaluate_t() NumPy warnings #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2022
Merged

evaluate_t() NumPy warnings #709

merged 4 commits into from
Oct 4, 2022

Conversation

@j-c-c
Copy link
Collaborator

@j-c-c j-c-c commented Oct 4, 2022

This addresses issue #701. There were several instances of evaluate_t() being passed NumPy arrays. All have been converted to Image/Volume instances.

@j-c-c j-c-c requested a review from garrettwrong October 4, 2022 16:49
@j-c-c j-c-c self-assigned this Oct 4, 2022
@j-c-c j-c-c added the cleanup label Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 4, 2022 •
edited
Loading

Codecov Report

Merging #709 (5a61ff3) into develop (3b3912f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #709      +/-   ##
===========================================
- Coverage    87.54%   87.50%   -0.05%     
===========================================
  Files          112      112              
  Lines         8373     8377       +4     
===========================================
  Hits          7330     7330              
- Misses        1043     1047       +4
Impacted Files Coverage Δ
src/aspire/basis/basis.py 88.31% <100.00%> (-0.88%) ⬇️
src/aspire/covariance/covar2d.py 95.52% <100.00%> (ø)
src/aspire/denoising/denoiser_cov2d.py 80.00% <100.00%> (ø)
src/aspire/reconstruction/estimator.py 92.40% <100.00%> (+0.09%) ⬆️
src/aspire/basis/pswf_2d.py 97.27% <0.00%> (-1.37%) ⬇️
src/aspire/basis/fpswf_2d.py 97.40% <0.00%> (-1.30%) ⬇️
src/aspire/image/image.py 89.94% <0.00%> (+0.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

garrettwrong
garrettwrong requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this real quick. Pretty close.

@j-c-c j-c-c marked this pull request as ready for review October 4, 2022 18:16
@j-c-c j-c-c requested a review from janden as a code owner October 4, 2022 18:16
@j-c-c j-c-c requested a review from garrettwrong October 4, 2022 18:46
@j-c-c j-c-c merged commit 6cc1c54 into develop Oct 4, 2022
@j-c-c j-c-c mentioned this pull request Oct 5, 2022
Merged
@j-c-c j-c-c deleted the evaluate_t_numpy_701 branch November 29, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janden janden janden approved these changes

@garrettwrong garrettwrong garrettwrong approved these changes

Assignees

@j-c-c j-c-c

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@j-c-c @janden @garrettwrong