Fix Image.set_metadata() bug
#648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #648 +/- ##
========================================
Coverage 86.49% 86.49%
========================================
Files 109 109
Lines 8286 8286
========================================
Hits 7167 7167
Misses 1119 1119
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
j-c-c
approved these changes
Jun 30, 2022
| ) | ||
| else: | ||
| self._metadata[metadata_field] = series | ||
| self._metadata.update(series.astype(object)) |
garrettwrong
approved these changes
Jul 8, 2022
Collaborator
garrettwrong
left a comment
garrettwrong
left a comment
There was a problem hiding this comment.
Looks good. Thanks Chris. Lets go ahead and merge this one too.
janden
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataFrame.update()takes care of what we were trying to do previously, which was including new data but setting old data toNaN.https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.update.html
See #635 for the original issue.
Also, by casting the series to dtype
object, when the same column exists in both the original DF, and the new DF it is being updated from, the dtype will default to that of the original DF. This fixes the second issue mentioned in #635.https://stackoverflow.com/a/47145613/9584059