Skip to content

Conversation

@chris-langfield
Copy link
Collaborator

@chris-langfield chris-langfield commented Jun 21, 2022

We just forgot to put the bad file in the temp directory so it never gets cleaned up.

Closes #629

@chris-langfield chris-langfield requested a review from janden as a code owner June 21, 2022 14:41
@chris-langfield chris-langfield self-assigned this Jun 21, 2022
@chris-langfield chris-langfield added CI Continuous Integration cleanup labels Jun 21, 2022
@chris-langfield chris-langfield linked an issue Jun 21, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #645 (5475047) into develop (1bff8d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #645   +/-   ##
========================================
  Coverage    86.49%   86.49%           
========================================
  Files          109      109           
  Lines         8286     8286           
========================================
  Hits          7167     7167           
  Misses        1119     1119           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@garrettwrong garrettwrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this. Checked the code out and confirmed the file is cleaned up.

@garrettwrong
Copy link
Collaborator

I think we can skip Joakim on this, its small and low risk. Merging.

@garrettwrong garrettwrong merged commit bb249d8 into develop Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running pytest leaves bad_applepick.star

3 participants