[Backport] Reload cart totals when cart data changes #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.2 develop
# Conflicts: # app/code/Magento/SalesRule/Test/Mftf/Section/AdminCartPriceRulesFormSection.xml
MAGETWO-69650: Simple product with flat tables enabled not showing correct price in shopping cart
…a zoom magento#18595 - Merge Pull Request magento#18595 from luukschakenraad/magento2:18585_2.2 - Merged commits: 1. ad09de9 2. e031bdc
[helix] MAGETWO-94670: Product Export fails
Fixes a typo on the aria-labeleledby attribute on the product page causing a W3C Validation error.
…tion to \Exception to fix docblock
Updates `getHostUrl()` method to reference `HTTP_HOST` rather than `SERVER_PORT`.
…"clone_field" system config feature.
…agento#18656 - Merge Pull Request magento#18656 from gelanivishal/magento2:2.2-develop-PR-port-18522 - Merged commits: 1. f7d8edd 2. af1e20e
…ed var error magento#18657 - Merge Pull Request magento#18657 from gelanivishal/magento2:2.2-develop-PR-port-18529 - Merged commits: 1. e6dedb7 2. c2a2a10 3. c77ffb8
Accepted Public Pull Requests: - magento#18876: [Backport] Fix Useless use of Cat (by @gelanivishal) - magento#18835: [Backport] Added Unit Test for WindowsSmtpConfig Plugin (by @vasilii-b) - magento#18834: [Backport] Cover \Magento\Email\Model\Template\SenderResolver class with Unit test (by @vasilii-b) - magento#18833: [Backport] Cover \Magento\GiftMessage\Observer\SalesEventQuoteMerge with Unit test (by @vasilii-b) - magento#17971: Don't format Special Price value for Bundle Product (by @magently) - magento#18681: [Backport] Set fallback values for email and _website columns to avoid 'undefined index' error in CustomerComposite.php (by @TomashKhamlai) Fixed GitHub Issues: - magento#17638: Bundle Special Prices not correctly rounded (reported by @Stassy) has been fixed in magento#17971 by @magently in 2.2-develop branch Related commits: 1. c63d1e6 2. 36570de 3. 1944299
… click anywhere on screen magento#18576 magento#18865
- Merge Pull Request magento#18372 from neeta-wagento/magento2:resolve-typo-despatch-event - Merged commits: 1. 5937495 2. e878105 3. 6178035 4. 2647a89
Accepted Public Pull Requests: - magento#18917: Fixed-Global-search icon misaligned (by @speedy008) - magento#18591: [Backport] Fix SKU limit in import new products (by @ravi-chandra3197) - magento#18862: [Backport] Adding trimming sku value function to sku backend model. (by @gelanivishal) - magento#18865: fixed issue magento#18458 : Alert widget gets close when click anywhere on screen magento#18576 (by @Shubham-Webkul) - magento#18886: [Backport] fixed Translation issue send-friend in send.phtml (by @rahulwebkul) Fixed GitHub Issues: - magento#18913: Global-search icon misaligned (reported by @speedy008) has been fixed in magento#18917 by @speedy008 in 2.2-develop branch Related commits: 1. 3cbc255 - magento#17865: import new products via csv: products are created with empty value when strings are too long (reported by @LouNik1984) has been fixed in magento#18591 by @ravi-chandra3197 in 2.2-develop branch Related commits: 1. e59dee0 2. a10f074 3. ad68105 - magento#12300: SKU values are not trimmed with the space. (reported by @ShaileshChauhan92) has been fixed in magento#18862 by @gelanivishal in 2.2-develop branch Related commits: 1. 109a27e - magento#16572: Trim whitespace on SKU when saving product (reported by @Zyles) has been fixed in magento#18862 by @gelanivishal in 2.2-develop branch Related commits: 1. 109a27e - magento#18458: Magento version 2.2.6 Alert widget gets close when click anywhere on screen (reported by @asgarh) has been fixed in magento#18865 by @Shubham-Webkul in 2.2-develop branch Related commits: 1. f59bc17 2. 06b243f 3. c3bc361 4. 26a9520 5. 87167e7 6. c6586ab 7. d40a26c 8. 84c7391 9. e1483f6 10. 3b2e4e4 11. 7dc2d1b - magento#18779: Translation issue send-friend in sendphtml (reported by @Franzld) has been fixed in magento#18886 by @rahulwebkul in 2.2-develop branch Related commits: 1. 443e681
…ltiple catalog product list wid… magento#18874
… does not update the last logged in data magento#17978
Accepted Public Pull Requests: - magento#18874: [Backport] Fixed issue magento#4468 "Unable to insert multiple catalog product list wid� (by @gelanivishal) - magento#18287: Ensure integer values are not quoted as strings (by @udovicic) - magento#17978: magento#17488 Fix Authenticating a customer via REST API does not update the last logged in data (by @prakashpatel07) Fixed GitHub Issues: - magento#4468: Unable to insert multiple catalog product list widgets in CMS page (reported by @kandrejevs) has been fixed in magento#18874 by @gelanivishal in 2.2-develop branch Related commits: 1. 3f17772 - magento#17488: Authenticating a customer via REST API does not update the last logged in data (reported by @paul-blundell) has been fixed in magento#17978 by @prakashpatel07 in 2.2-develop branch Related commits: 1. d73e84f 2. 9a4f260 3. 55047c7 4. da2c920 5. e8636ef 6. 141b0e4
…ling address used on Cart and Checkout magento#18863
…pping methods with under… magento#18870
Accepted Public Pull Requests: - magento#18372: Resolve typo despatch event (by @neeta-wagento) - magento#18863: [Backport] magento#17744 Adding logic to get default billing address used on Cart and Checkout (by @gelanivishal) - magento#18870: [Backport] ISSUE-5021 - fixed place order for custom shipping methods with under� (by @gelanivishal) - magento#18872: [Backport] Allow set billing information via API with existing address (by @gelanivishal) Fixed GitHub Issues: - magento#18355: Typo in dispatched event name (reported by @MTheProgrammer) has been fixed in magento#18372 by @neeta-wagento in 2.2-develop branch Related commits: 1. 5937495 2. e878105 3. 6178035 4. 2647a89 - magento#17744: Virtual-only quotes use default shipping address for estimation instead of default billing address (reported by @navarr) has been fixed in magento#18863 by @gelanivishal in 2.2-develop branch Related commits: 1. b57ae01 2. f7a8160 3. f3f9cff 4. 3836bd2 5. d88d133 6. 7116fed - magento#5021: "Please specify a shipping method" Exception (reported by @vphat28) has been fixed in magento#18870 by @gelanivishal in 2.2-develop branch Related commits: 1. 70cebbd - magento#17485: Adding billing information via mine API expects costumer id (reported by @wittyvishwas) has been fixed in magento#18872 by @gelanivishal in 2.2-develop branch Related commits: 1. fdf855c
[performance] MAGETWO-95206: Investigate all becnhmark improvements delivery to infra mainline
tdgroot
pushed a commit
that referenced
this pull request
Nov 1, 2018
tdgroot
pushed a commit
that referenced
this pull request
Nov 1, 2018
tdgroot
pushed a commit
that referenced
this pull request
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#18700
Description (*)
When cart data changes on cart view, the totals need to be reloaded. For example, when the qty changes, the totals of the cart data change as well.
This normally doesn't happen in default Magento, because cart mutations reload the entire page. I stumbled upon this problem when creating an extension that allows the customer to change qty without reloading the page.
Manual testing scenarios (*)
I can't really provide steps to reproduce my situation, because core Magento doesn't do javascript cart mutations on the cart view. But, when adding items to cart, the totals should be rendered properly. This change shouldn't affect the usual totals estimation. So here you go:
Contribution checklist (*)