-
Notifications
You must be signed in to change notification settings - Fork 9.4k
fixed issue #18458 : Alert widget gets close when click anywhere on screen #18576 #18865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue #18458 : Alert widget gets close when click anywhere on screen #18576 #18865
Conversation
Hi @Shubham-Webkul. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Shubham-Webkul ,
thanks for your contribution and for your time.
Hi @phoenix128, thank you for the review. |
Hi @Shubham-Webkul. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Alert widget extend modal widget and modal widget has "clickableOverlay" configuration option. |
Description (*)
Description
In older version of magento 2.2.6 when we click delete button of minicart then alert widget display for confirm to delete item from cart.This popup was only close when click on "cancel", "ok" & "close" button.But earlier version of magento 2.2.6 it is closing click anywhere on screen.In this PR i have fixed this issue.
Fixed Issues (if relevant)
Manual testing scenarios (*)
1 - Add product into cart.
2- Click on cart logo and delete item from cart.
3 - Now popup will open for confirm.
4 - Click anywhere on screen.Now popup will not close.
Contribution checklist (*)