Skip to content

Conversation

magently
Copy link

@magently magently commented Sep 7, 2018

Description

Pull Request solves the problem with incorrect rounding of Special Price in case of Bundle Product. In Bundle Products, Special Price is a percentage value, not a price that can be formatted (such as rounding).
The solution is not to format the value in this case as a price.

Fixed Issues (if relevant)

  1. Bundle Special Prices not correctly rounded #17638: Bundle Special Prices not correctly rounded

Manual testing scenarios

Same as in the issue

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar rogyar self-assigned this Sep 8, 2018
@rogyar
Copy link
Contributor

rogyar commented Sep 8, 2018

Hi @magently. Thank you for your contribution. Please, consider fixing the mentioned issues

@magently
Copy link
Author

Hello @rogyar

We fixed the cyclomatic complexity like you asked.

I hope it is more clear now. It will skip the price formatting only in case of special prices in bundle products.

@slavvka
Copy link
Member

slavvka commented Oct 2, 2018

Hey @magently I still can see cyclomatic complexity is 10. Please fix that
/home/travis/build/magento/magento2/app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav.php:387 The method modifyData() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.

@sidolov
Copy link
Contributor

sidolov commented Oct 17, 2018

Hi @magently , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Oct 17, 2018
@magento-engcom-team
Copy link
Contributor

Hi @magently. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants