-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Don't format Special Price value for Bundle Product #17971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't format Special Price value for Bundle Product #17971
Conversation
Hi @magently. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav.php
Outdated
Show resolved
Hide resolved
app/code/Magento/Catalog/Ui/DataProvider/Product/Form/Modifier/Eav.php
Outdated
Show resolved
Hide resolved
Hi @magently. Thank you for your contribution. Please, consider fixing the mentioned issues |
Hello @rogyar We fixed the cyclomatic complexity like you asked. I hope it is more clear now. It will skip the price formatting only in case of special prices in bundle products. |
Hey @magently I still can see cyclomatic complexity is 10. Please fix that |
Hi @magently , I am closing this PR now due to inactivity. |
Hi @magently. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
Pull Request solves the problem with incorrect rounding of Special Price in case of Bundle Product. In Bundle Products, Special Price is a percentage value, not a price that can be formatted (such as rounding).
The solution is not to format the value in this case as a price.
Fixed Issues (if relevant)
Manual testing scenarios
Same as in the issue
Contribution checklist