Skip to content

Conversation

SyntaxKay
Copy link
Contributor

@SyntaxKay SyntaxKay commented Oct 29, 2018

Description (*)

Global-search icon misaligned

Fixed Issues (if relevant)

  1. Global-search icon misaligned  #18913: Global-search icon misaligned

Manual testing scenarios (*)

1.N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@SyntaxKay SyntaxKay changed the title Fixed-Global-search icon misaligned-#18913 Fixed-Global-search icon misaligned Oct 29, 2018
@VladimirZaets VladimirZaets self-assigned this Oct 29, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3322 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @speedy008. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants