Skip to content

Use attribute name in message for "outer attr used as inner attr" errors #145792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

Use attribute name in message for "outer attr used as inner attr" errors #145792

merged 1 commit into from
Aug 27, 2025
+691 −213

Conversation

scrabsha
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Aug 23, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Aug 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 23, 2025

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 23, 2025
@scrabsha
Copy link
Contributor Author

Discussed with @jdonszelmann: this does not work for the new attribute infrastructure. Ideally we want the each *Parser implementation to say whether an attribute is a crate-level or normal attribute.

@jdonszelmann
Copy link
Contributor

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 24, 2025
@jdonszelmann jdonszelmann mentioned this pull request Aug 24, 2025
Open
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@scrabsha
Copy link
Contributor Author

scrabsha commented Aug 24, 2025 •
edited
Loading

The force-push contains:

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2025
@scrabsha scrabsha mentioned this pull request Aug 24, 2025
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jdonszelmann
jdonszelmann reviewed Aug 25, 2025
View reviewed changes
scrabsha
scrabsha commented Aug 25, 2025
View reviewed changes
scrabsha
scrabsha commented Aug 25, 2025
View reviewed changes
compiler/rustc_passes/src/errors.rs
Comment on lines +67 to +77
pub(crate) struct OuterCrateLevelAttr {
#[subdiagnostic]
pub suggestion: OuterCrateLevelAttrSuggestion,
}

#[derive(Subdiagnostic)]
#[multipart_suggestion(passes_outer_crate_level_attr_suggestion, style = "verbose")]
pub(crate) struct OuterCrateLevelAttrSuggestion {
#[suggestion_part(code = "!")]
pub bang_position: Span,
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i spent a long time trying to figure out how to make a correct subdiagnostic and i would not be surprised if this was massively suboptimal. reviewer, please double-check this bit :3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's alright, at least similar to ones I've made before.

jdonszelmann
jdonszelmann approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@jdonszelmann jdonszelmann left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

View changes since this review

@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 26, 2025

📌 Commit a8e9ca1 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 26, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 26, 2025
@samueltardieu samueltardieu mentioned this pull request Aug 26, 2025
Merged
bors added a commit that referenced this pull request Aug 26, 2025
@bors
Auto merge of #145906 - samueltardieu:rollup-p8ibzhz, r=samueltardieu
176d8db 
Rollup of 9 pull requests

Successful merges:

 - #144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`)
 - #145790 (Improve dist for gnullvm hosts)
 - #145792 (Use attribute name in message for "outer attr used as inner attr" errors)
 - #145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags)
 - #145876 (Enable building/disting standard library in stage 0)
 - #145887 (bootstrap: Don't panic if codegen-backends is set to empty)
 - #145888 (platform-support: Fix LoongArch32 host column)
 - #145892 (add a flag to codegen fn attrs for foreign items)
 - #145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fbf247d into rust-lang:master Aug 27, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 27, 2025
rust-timer added a commit that referenced this pull request Aug 27, 2025
@rust-timer
Unrolled build for #145792
09b5fbd 
Rollup merge of #145792 - scrabsha:push-umpytyxunpxq, r=jdonszelmann

Use attribute name in message for "outer attr used as inner attr" errors
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Aug 27, 2025
@bors
Auto merge of #145906 - samueltardieu:rollup-p8ibzhz, r=samueltardieu
197d503 
Rollup of 9 pull requests

Successful merges:

 - rust-lang/rust#144499 (ci: Begin running ui tests with `rust.debuginfo-level-tests=1`)
 - rust-lang/rust#145790 (Improve dist for gnullvm hosts)
 - rust-lang/rust#145792 (Use attribute name in message for "outer attr used as inner attr" errors)
 - rust-lang/rust#145840 (rustc_codegen_ssa: More comprehensive RISC-V ELF flags)
 - rust-lang/rust#145876 (Enable building/disting standard library in stage 0)
 - rust-lang/rust#145887 (bootstrap: Don't panic if codegen-backends is set to empty)
 - rust-lang/rust#145888 (platform-support: Fix LoongArch32 host column)
 - rust-lang/rust#145892 (add a flag to codegen fn attrs for foreign items)
 - rust-lang/rust#145901 (Fix typo in comment of library/alloc/src/raw_vec/mod.rs)

r? `@ghost`
`@rustbot` modify labels: rollup
@scrabsha scrabsha deleted the push-umpytyxunpxq branch August 27, 2025 07:59
@scrabsha scrabsha mentioned this pull request Sep 1, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonszelmann jdonszelmann jdonszelmann approved these changes

Assignees

@jdonszelmann jdonszelmann

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
5 participants
@scrabsha @rustbot @jdonszelmann @rust-log-analyzer @bors