-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Port limit attributes to the new attribute parsing infrastructure #145819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This comment has been minimized.
This comment has been minimized.
@jdonszelmann #145792 is mostly ready so you can probably rebase now :3 |
This comment was marked as resolved.
This comment was marked as resolved.
835549e
to
995056a
Compare
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred to the CTFE machinery |
This comment has been minimized.
This comment has been minimized.
995056a
to
11da338
Compare
does conflict with #145937 but it's an easy rebase so we'll just see what merges first |
@@ -6,15 +6,5 @@ LL | #![recursion_limit = "-100"] | |||
| | | |||
| not a valid integer | |||
|
|||
error: `limit` must be a non-negative integer | |||
--> $DIR/invalid_digit.rs:3:1 | |||
| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doubled up error cannot be prevented. If we do, we'd get a similar situation as with crate_name where we either forget some cases, or delay as bug giving an ice when this literal happens to be a macro that before expansion is invalid but expanded is valid. e.g. concat!("100")
which before expansion is an expression we should reject but after expansion is a perfectly valid integer literal
11da338
to
06599a5
Compare
I presume this fixes some of these reported ICEs: #145922? You don't need to add regression tests, not worth it I think. |
☔ The latest upstream changes (presumably #145958) made this pull request unmergeable. Please resolve the merge conflicts. |
I think the ices are already mostly fixed because we don't delay bugs anymore for this specific case. So I think it's fixed without this pr but we'll want this anyway |
Doesn't pass tests, to be rebased on #145792 which will solve that
r? @fmease