Port `#[crate_name]` to the new attribute parsing infrastructure #137729

jdonszelmann · 2025-02-27T13:57:10Z

r? @fmease

Closes #137687

compiler/rustc_driver_impl/src/lib.rs

compiler/rustc_attr_data_structures/src/attributes.rs

compiler/rustc_attr_parsing/src/attributes/crate_name.rs

jdonszelmann · 2025-03-06T16:12:47Z

@fmease and I decided to delay this PR for a bit until more diagnostic infra for attrs lands (hopefully next week) to make the duplicate error a warning to be consistent with current master.

fmease · 2025-03-06T16:14:30Z

r=fmease,bjorn3 once that PR lands and you can downgrade the error to a lint warning again.

@bors delegate+

bors · 2025-03-06T16:14:34Z

✌️ @jdonszelmann, you can now approve this pull request!

If @fmease told you to "r=me" after making some further change, please make that change, then do @bors r=@fmease

wesleywiser · 2025-04-24T14:46:44Z

Hi @jdonszelmann and @fmease, #137687 has reached beta so it would be great if we could resolve that via a beta-backport of this PR. Do you think it's possible to resolve the review feedback and merge this PR in the next week or so?

I can probably pitch in to help if necessary 🙂

jdonszelmann · 2025-04-24T14:50:11Z

Hi there. We wanted to delay this until attribute diagnostics. Something that should not be a lot of work but I have not worked as much on recently as I maybe should. I can't to this tomorrow, but likely next week. The pr has been reviewed but there was a bit of an issue around incremental, which I now know how to solve but just haven't yet. Is that a reasonable timeframe? I am pretty busy with organising rust week atm, but knowing the solution I guess the only important thing is that it gets quick reviews? Let me know how that sounds

wesleywiser · 2025-04-24T14:53:12Z

Just to clarify, will this PR then depend on the attribute diagnostics work? (Is that #138164?)

Generally, for backports, we try to keep the backport as small as possible so if this PR can be made to work independently of that PR (possibly even with a degraded diagnostics experience), that would be highly preferred.

jdonszelmann · 2025-04-24T16:28:00Z

No. We decided to delay this because it's relatively low prio and any nice and permanent solution for this depends on that. I'll make a temp fix that at least doesn't ice separately then, that sounds better for now. I don't mind doing it, I know the problem now and then I also know how to fix it permanently later. You'll hear from me

theemathas · 2025-05-01T14:19:57Z

Note that #137687 actually has two separate problems/subissues:

A problem (lower priority) involving the #[crate_name] attribute.
A problem (higher priority, found in a crater run) involving user-defined macro_rules and derive macros.

This PR only appears to address the first problem. The second problem would probably need to have a separate fix.

jdonszelmann · 2025-05-02T13:23:01Z

ok this is weird, I've copied just the tests over to master to fix it in a temporary way, but can no longer reporoduce the issue. Something else must have solved it in the meantime. Let me see what.

jieyouxu · 2025-05-03T09:36:54Z

(I know I've said this in the other PR too, but just in case)

Just a heads up: I split #137687 into two issues:

ICE: expr in place where literal is expected (builtin attr parsing) #137687 is used to track Matthias's fuzzed regression (the #[crate_name = concat!("Cloneb")] one).
regression: ICE: expr in place where literal is expected (builtin attr parsing) #140612 is used to track the crater regressions (known to affect user macros)

tests/ui/lint/unused/unused-attr-duplicate.rs

compiler/rustc_lint_defs/src/lib.rs

bors · 2025-08-22T02:30:13Z

☔ The latest upstream changes (presumably #145728) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2025-08-23T12:15:49Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2025-08-23T12:15:51Z

This PR just keeps on giving hehe

jdonszelmann · 2025-08-23T12:16:15Z

rebased to incorporate @joshtriplett 's changes to early lints which makes things much nicer.

tests/ui/lint/unused/unused-attr-duplicate.stderr

tests/ui/lint/unused/unused_attributes-must_use.fixed

tests/ui/lint/unused/unused_attributes-must_use.stderr

jdonszelmann · 2025-08-23T18:00:18Z

compiler/rustc_attr_parsing/src/parser.rs

@@ -361,12 +362,8 @@ fn expr_to_lit(
        //   the error because an earlier error will have already
        //   been reported.
        let msg = "attribute value must be a literal";
-        let mut err = psess.dcx().struct_span_err(span, msg);


there's a subtle bug in this version, fixed in my last commit. When an expression in an attribute is a macro, and the macro expands to a literal, and we parse an attribute with ShouldEmit::Nothing, we would delay that as a bug expecting a second parse to emit the error. However, when the macro then expands to a literal, we don't hit the same codepath and we never emit an error about this. The delayed bug turns into an ICE.

A very similar problem was happening in February already (#137687) which was recognized and even a backport was made for it. However, in later versions it still made it to stable.

The last commit of this PR adds tests for these cases and fixes this by, when we expect a literal, but have ShouldEmit::Nothing, we don't delay a bug, instead we do nothing. This is correct because if the macro indeed turns into a literal, the second parse might very well be correct. We shouldn't have delayed a bug at all.

Specifically for crate_name, we parse with ShouldEmit::EarlyFatal so when it cares about this being a literal, it will error about it as it should.

jdonszelmann · 2025-08-23T18:01:55Z

tests/ui/resolve/path-attr-in-const-block.stderr

+error: attribute value must be a literal
+  --> $DIR/path-attr-in-const-block.rs:6:19
+   |
+LL |         #![path = foo!()]


extra error, but this is correct/expected. bonus!

jdonszelmann · 2025-08-23T18:02:54Z

tests/ui/lint/unused/concat-in-crate-deprecated-issue-137687.rs

@@ -0,0 +1,6 @@
+//@ check-pass
+#[deprecated = concat !()]


regression test for a new case of #137687

ICE on stable currently: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=aea39cc8b7e80959b032d48976fe98fa

jdonszelmann · 2025-08-23T18:03:44Z

tests/ui/lint/unused/concat-in-crate-name-issue-137687.rs

@@ -0,0 +1,9 @@
+#![deny(unused)]
+
+#[crate_name = concat !()]


regression test for #137687 (ICEs on stable currently: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=fc3557244535c7ed2a625b5741cc6e5f)

rustbot assigned fmease Feb 27, 2025

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2025

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the fix-137687 branch from 04bafec to 3898182 Compare February 27, 2025 14:07

This comment has been minimized.

Sign in to view

jdonszelmann force-pushed the fix-137687 branch from 3898182 to 81fc9d1 Compare February 27, 2025 14:39

bjorn3 reviewed Feb 27, 2025

View reviewed changes

compiler/rustc_driver_impl/src/lib.rs Outdated Show resolved Hide resolved

jdonszelmann force-pushed the fix-137687 branch 2 times, most recently from 4e90cee to 21838d5 Compare February 27, 2025 16:51

bjorn3 reviewed Feb 27, 2025

View reviewed changes

compiler/rustc_driver_impl/src/lib.rs Outdated Show resolved Hide resolved

jdonszelmann force-pushed the fix-137687 branch from 21838d5 to d1ee9c4 Compare February 27, 2025 17:44

fmease approved these changes Mar 6, 2025

View reviewed changes

compiler/rustc_attr_data_structures/src/attributes.rs Outdated Show resolved Hide resolved

compiler/rustc_attr_parsing/src/attributes/crate_name.rs Outdated Show resolved Hide resolved

compiler/rustc_attr_parsing/src/attributes/crate_name.rs Outdated Show resolved Hide resolved

fmease added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025

This comment was marked as resolved.

Sign in to view

fmease mentioned this pull request May 2, 2025

add test to reproduce #137687 and add a hotfix #140584

Closed

jdonszelmann mentioned this pull request Jun 13, 2025

Tracking issue: Attribute refactor #131229

Open

9 tasks

jdonszelmann force-pushed the fix-137687 branch from d1ee9c4 to 1f5c49f Compare August 11, 2025 12:50

fmease changed the title ~~add test to reproduce #137687 and fix it by converting #[crate_name] to a new-style attribute parser~~ Convert #[crate_name] to a new-style attribute parser Aug 21, 2025

fmease reviewed Aug 21, 2025

View reviewed changes

tests/ui/lint/unused/unused-attr-duplicate.rs Outdated Show resolved Hide resolved

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2025

fmease changed the title ~~Convert #[crate_name] to a new-style attribute parser~~ Port #[crate_name] to the new attribute parsing infrastructure Aug 21, 2025

joshtriplett reviewed Aug 21, 2025

View reviewed changes

compiler/rustc_lint_defs/src/lib.rs Outdated Show resolved Hide resolved

jdonszelmann mentioned this pull request Aug 22, 2025

Refactor lint buffering to avoid requiring a giant enum #145747

Merged

jdonszelmann force-pushed the fix-137687 branch from e8dac5d to 91f38e2 Compare August 23, 2025 12:15

jdonszelmann commented Aug 23, 2025

View reviewed changes

tests/ui/lint/unused/unused-attr-duplicate.stderr Show resolved Hide resolved

jdonszelmann commented Aug 23, 2025

View reviewed changes

tests/ui/lint/unused/unused-attr-duplicate.stderr Show resolved Hide resolved

jdonszelmann commented Aug 23, 2025

View reviewed changes

tests/ui/lint/unused/unused_attributes-must_use.fixed Show resolved Hide resolved

jdonszelmann commented Aug 23, 2025

View reviewed changes

tests/ui/lint/unused/unused_attributes-must_use.stderr Show resolved Hide resolved

jdonszelmann force-pushed the fix-137687 branch 2 times, most recently from 1a239f7 to 5dede49 Compare August 23, 2025 12:32

jdonszelmann added 2 commits August 23, 2025 17:03

Allow errors to be emitted as fatal during attribute parsing

097f40c

Support lints in early attribute parsing

020b268

jdonszelmann force-pushed the fix-137687 branch from 5dede49 to cfeb113 Compare August 23, 2025 15:13

Port crate name to the new attribute system

7f9f26b

jdonszelmann force-pushed the fix-137687 branch from cfeb113 to d146c5d Compare August 23, 2025 17:52

jdonszelmann commented Aug 23, 2025

View reviewed changes

jdonszelmann mentioned this pull request Aug 23, 2025

ICE: expr in place where literal is expected (builtin attr parsing) #137687

Open

fix ICE on stable related to attrs on macros

9a7d66d

jdonszelmann force-pushed the fix-137687 branch from d146c5d to 9a7d66d Compare August 23, 2025 18:53

Port #[crate_name] to the new attribute parsing infrastructure #137729

Are you sure you want to change the base?

Port #[crate_name] to the new attribute parsing infrastructure #137729

Conversation

jdonszelmann commented Feb 27, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jdonszelmann commented Mar 6, 2025

Uh oh!

fmease commented Mar 6, 2025

Uh oh!

bors commented Mar 6, 2025

Uh oh!

This comment was marked as resolved.

wesleywiser commented Apr 24, 2025

Uh oh!

jdonszelmann commented Apr 24, 2025

Uh oh!

wesleywiser commented Apr 24, 2025

Uh oh!

jdonszelmann commented Apr 24, 2025

Uh oh!

theemathas commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdonszelmann commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented May 3, 2025

Uh oh!

Uh oh!

Uh oh!

bors commented Aug 22, 2025

Uh oh!

rustbot commented Aug 23, 2025

Uh oh!

jdonszelmann commented Aug 23, 2025

Uh oh!

jdonszelmann commented Aug 23, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jdonszelmann Aug 23, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Aug 23, 2025

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Aug 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmann Aug 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Port `#[crate_name]` to the new attribute parsing infrastructure #137729

Port `#[crate_name]` to the new attribute parsing infrastructure #137729

jdonszelmann commented Feb 27, 2025 •

edited by rustbot

Loading

theemathas commented May 1, 2025 •

edited

Loading

jdonszelmann commented May 2, 2025 •

edited

Loading

jdonszelmann Aug 23, 2025 •

edited

Loading

jdonszelmann Aug 23, 2025 •

edited

Loading