Deprecate prefix_is_for_params of PidROS

[christophfroehlich]

See #156 (comment)

Fixes #156

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 95.59748% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.75%. Comparing base (4504fcf) to head (4f640e1).

Files with missing lines	Patch %	Lines
control_toolbox/test/pid_ros_publisher_tests.cpp	93.90%	0 Missing and 5 partials ⚠️
control_toolbox/src/pid_ros.cpp	93.33%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           ros2-master     #431      +/-   ##
===============================================
- Coverage        78.25%   77.75%   -0.51%     
===============================================
  Files               30       30              
  Lines             1890     2009     +119     
  Branches           114      125      +11     
===============================================
+ Hits              1479     1562      +83     
- Misses             342      379      +37     
+ Partials            69       68       -1     

Flag	Coverage Δ
unittests	77.75% <95.59%> (-0.51%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ontrol_toolbox/include/control_toolbox/pid_ros.hpp	100.00% <100.00%> (ø)
control_toolbox/test/pid_ros_parameters_tests.cpp	100.00% <100.00%> (ø)
control_toolbox/src/pid_ros.cpp	64.22% <93.33%> (-6.63%)	⬇️
control_toolbox/test/pid_ros_publisher_tests.cpp	94.65% <93.90%> (-1.50%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[saikishor]

Overall looks great.

Thank you :)

[saikishor]

The changes itself look good to me.

Just a nitpick on the parameter naming that I left as a comment.

[destogl]

Small clarification on default behavior. Otherwise good!

[saikishor]

LGTM

[destogl]

Thanks! Let's also accept the @saikishor's proposal