Apply API change of PidROS #1823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
hold
github-actions
bot
requested review from
VX792,
destogl,
mhubii,
moriarty,
olivier-stasse,
saikishor and
xguay
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1823 +/- ##
=======================================
Coverage 85.66% 85.66%
=======================================
Files 123 123
Lines 12407 12407
Branches 1056 1056
=======================================
Hits 10628 10628
Misses 1430 1430
Partials 349 349
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
previously approved these changes
Jul 21, 2025
christophfroehlich
removed
the
hold
saikishor
approved these changes
Jul 22, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
(cherry picked from commit 0f51de6) # Conflicts: # doc/migration.rst # doc/release_notes.rst
christophfroehlich
pushed a commit
that referenced
this pull request
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ros-controls/control_toolbox#431
Earlier, the state was published to global
/<controller_name>/<dof_name>/pid_stateinstead. Should we better not change this?