build(next): Add test setup #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
thien-remote
left a comment
thien-remote
left a comment
There was a problem hiding this comment.
Thanks @dragidavid this is excellent! Not an approval yet because I want to try simplifying the test build a bit. Will keep you updated
thien-remote
changed the title
thien-remote
changed the title
* Fix * Update jest.config.js * Update babel.config.js * chore: add default node version --------- Co-authored-by: David Dragovacz <[email protected]>
thien-remote
previously approved these changes
Jan 22, 2025
Collaborator
|
Approving as my comments are not blockers |
antoniocapelo
previously approved these changes
Jan 22, 2025
dragidavid
dismissed stale reviews from antoniocapelo and thien-remote
via
f3e3b79
antoniocapelo
approved these changes
Jan 22, 2025
thien-remote
approved these changes
Jan 23, 2025
sandrina-p
reviewed
Jan 23, 2025
| const config = { | ||
| roots, | ||
| moduleNameMapper, | ||
| testPathIgnorePatterns, |
Collaborator
There was a problem hiding this comment.
praise: This entire PR is very smart, TIL about this for moduleNameMapper 💡 💡 💡
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow up on #108 and #110, this PR adds the test script to
next. It belongs to the same internal ticket of DEVXP-2530.moduleNameMapperin thejest.config.mjsfile to map the imports to the files in thenextfolder. This only happens when we run thetestscript from within thenextfolder. Otherwise everything is unaffected.nvmrcandenginesso we can make sure everyone uses the correct node version (LTS)