-
Notifications
You must be signed in to change notification settings - Fork 19
Set up V2 project: Lint #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey reviewers 👋 (I suppose you should receive the notification so no extra tagging here) Do you think we could review this one as-is, or do you want to wait until we have a complete workflow (build + test + release)? |
lukad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @thien-remote.
I don't have any strong oppinions on the linter config, etc.
(Look like we haven't had a PR template?)
TL;DR:
Hey 👋 This PR set up a new project called "next". This is going to be the working place for Version 2 of JSON Schema Form, see Linear.
(This is a sponsored work from Remote, so there might be Remote's internal URLs like above in this description. I'll try to keep that to a minimum though.)
Overview
I actually end up with setting up the lint first 😅 I think it's good to have the automated lint in as soon as possible, so we will have less chance of code style or format conflicts in the future.
Instead of the 10+ direct dependencies just for setting up ESLint in V1, I opt to use antfu/eslint-config in V2. This means:
Another thing is the version will start with
.alphasuffix. This is both to indicate the work-in-progress nature of the package, and also to reduce confusion with the "beta" tag we are using in V1.It's worth to note that we will still use the "dev" tag and "dev" suffix like V1 though. That will be cover in a different PR for release.