Skip to content

Conversation

@thien-remote
Copy link
Collaborator

(Look like we haven't had a PR template?)

TL;DR:

Hey 👋 This PR set up a new project called "next". This is going to be the working place for Version 2 of JSON Schema Form, see Linear.

(This is a sponsored work from Remote, so there might be Remote's internal URLs like above in this description. I'll try to keep that to a minimum though.)

Overview

I actually end up with setting up the lint first 😅 I think it's good to have the automated lint in as soon as possible, so we will have less chance of code style or format conflicts in the future.

Instead of the 10+ direct dependencies just for setting up ESLint in V1, I opt to use antfu/eslint-config in V2. This means:

  1. We are on latest ESLint!
  2. We have only 1 dependency! Albeit we still have a huge lock file, that can't be helped.
  3. Did I mention we no longer need Prettier?

Another thing is the version will start with .alpha suffix. This is both to indicate the work-in-progress nature of the package, and also to reduce confusion with the "beta" tag we are using in V1.

It's worth to note that we will still use the "dev" tag and "dev" suffix like V1 though. That will be cover in a different PR for release.

@thien-remote thien-remote self-assigned this Jan 20, 2025
@thien-remote thien-remote changed the title Set up V2 project Set up V2 project: Lint Jan 20, 2025
@thien-remote
Copy link
Collaborator Author

Hey reviewers 👋 (I suppose you should receive the notification so no extra tagging here)

Do you think we could review this one as-is, or do you want to wait until we have a complete workflow (build + test + release)?

@sandrina-p sandrina-p requested review from lukad and removed request for sandrina-p January 20, 2025 13:14
Copy link
Collaborator

@lukad lukad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @thien-remote.
I don't have any strong oppinions on the linter config, etc.

@thien-remote thien-remote merged commit 038efcf into main Jan 21, 2025
3 checks passed
@thien-remote thien-remote deleted the devxp-2530-set-up branch January 21, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants