build(next): Add build step #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thien-remote
force-pushed
the
devxp-2530-build
branch
from
f733362 to
0f25a29
Compare
wip build(next): Switch to 1.0 build(next): Add lint Co-Authored-By: David Dragovacz <[email protected]>
thien-remote
force-pushed
the
devxp-2530-build
branch
from
0f25a29 to
d2dfd27
Compare
thien-remote
commented
Jan 21, 2025
Collaborator
Author
thien-remote
left a comment
thien-remote
left a comment
There was a problem hiding this comment.
@sandrina-p @dragidavid this is ready for review now!
@antoniocapelo @lukad FYI
| "sourcemap": true, | ||
| "minify": true, | ||
| "target": "es2020", | ||
| "outDir": "dist" |
Collaborator
There was a problem hiding this comment.
Question
Should we update our package.json main value include the dist folder?
Collaborator
Author
There was a problem hiding this comment.
Oh yes we missed that 😆 I intend to do that in the Release step, last step of the setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow up on #108, this PR adds the Build step. It belongs to the same internal ticket of DEVXP-2530.
Unlike V1, we will use tsup now. Fun fact: it's built on top of esbuild, which is what we are using in V1. I actually don't know why V1 has Babel along though. Anyway, we will have a minimal build setup for V2: one config for TypeScript, and one for tsup.
(Reminder for contributors: add "tsup" to your spell check dictionary from now!)
That's it! That's the change. You can try it with
pnpm run buildright now.