add filter for binary_linux_wheel_py3.7_cpu #3998
Conversation
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks for the PR @mattip!
I'm trying to understand a few things:
The important part is to add a filter for tags, otherwise the tag commit does not trigger a documentation build and upload.
Why do we only need the tag for binary_linux_wheel_py3.7_cpu?
The CircleCI docs say:
CircleCI does not run workflows for tags unless you explicitly specify tag filters. Additionally, if a job requires any other jobs (directly or indirectly), you must specify tag filters for those jobs.
So, since the dependency between our jobs is upload_docs -> build_docs -> binary_linux_wheel_py3.7_cpu, shouldn't we also add the tag filter for build_docs, which is currently missing?
.circleci/regenerate.py
Outdated
| fb = "master" | ||
| if not fb and (os_type == 'linux' and cu_version == 'cpu' and | ||
| btype == 'wheel' and python_version =='3.7'): | ||
| # this is for build_docs, the versions must match |
There was a problem hiding this comment.
I'm not sure I understand this comment: what is "versions", and what should it match with?
Good point. Added and rebased off master. |
datumbox
left a comment
datumbox
left a comment
There was a problem hiding this comment.
@mattip Thanks for fixing it. There are some related lint issues. Could you please check?
|
So the way we actually do this in upstream |
|
Anything else needed here? It seems this goes out-of-date every night, so if needed I can update |
| if not filter_branch: | ||
| # Build on every pull request, but upload only on nightly and tags | ||
| w += build_doc_job(None) | ||
| w += build_doc_job('nightly') |
There was a problem hiding this comment.
@mattip does this mean that the docs are not build on every PR anymore?
There was a problem hiding this comment.
hmm. It seems to be building on PRs, for instance taking a random PR and looking at the CI build I see a build_docs run 2/3 of the way down. Although I agree the filter says only nightly, so it is misleading.
- build_docs:
filters:
branches:
only:
- nightly
tags:
only: /v[0-9]+(\.[0-9]+)*-rc[0-9]+/
name: build_docs
python_version: '3.7'
requires:
- binary_linux_wheel_py3.7_cpu
There was a problem hiding this comment.
I'm afraid the PR you're linking to was pushed before this one got merged.
In more recent commits, e.g. https://app.circleci.com/pipelines/github/pytorch/vision?branch=pull%2F3808 from this morning, I do not see the build_docs job.
Summary: * add filter for binary_linux_wheel_py3.7_cpu fixes issue #3997 * add tag,nightly filter to build_docs * flake8 formatting * fixes from review Reviewed By: fmassa Differential Revision: D29097738 fbshipit-source-id: d4c6a0b3b9d3bfc9a20fffd003748cd417b3a877
7 participants
fixes issue #3997
The important part is to add a filter for tags, otherwise the tag commit does not trigger a documentation build and upload.