always run build_docs in CI #4053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Weird, I still don't see the @NicolasHug do you know what might be happening? |
Member
|
I don't know for sure, but maybe this is one of these cases where we need to merge the PR to see the effective changes? |
fmassa
reviewed
Jun 14, 2021
| branches: | ||
| only: | ||
| - nightly | ||
| - '*' |
Member
There was a problem hiding this comment.
Do you think the doc job is not being run because we have ' around the *?
Contributor
Author
There was a problem hiding this comment.
The filter with the '*' is the same as the base job build_docs runs off (binary_linux_wheel_py3.7_cpu) which works fine.
- binary_linux_wheel:
conda_docker_image: pytorch/conda-builder:cpu
cu_version: cpu
filters:
branches:
only: '*'
tags:
only: /v[0-9]+(\.[0-9]+)*-rc[0-9]+/
name: binary_linux_wheel_py3.7_cpu
python_version: '3.7'
wheel_docker_image: pytorch/manylinux-cuda102
malfet
approved these changes
Jun 14, 2021
|
Hey @malfet! You approved or merged this PR, but no labels were added. |
This was referenced Jun 15, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 15, 2021
Reviewed By: mthrok Differential Revision: D29105973 fbshipit-source-id: 4179ab333f82d99765ee594eebcf81b4d4c1715e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3998. In that PR,
build_docswas mistakenly restricted to nightly and tags, see this comment@fmassa