Skip to content

Conversation

@mattip
Copy link
Contributor

@mattip mattip commented Jun 15, 2021

Port pytorch/vision#3998 and pytorch/vision#4053 so that adding a tag will trigger a documentation build-and-upload. The problem was that the upload depends on both the wheel and the build_docs builds, but those did not have the correct filter so they were not running.

Similar to pytorch/text#1332

It would be nice to see this merged before the next tag event, to make sure the docs are now building (the last few tags did not generate docs), although #1568 already generated the 0.9 docs.

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

I am pretty sure this needs to be cherry-picked to the 0.9 release branch

only:
- /.*/
tags:
only: /v[0-9]+(\.[0-9]+)*-rc[0-9]+/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattip

This regex looks like it will only match RC. Is this intended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mthrok mthrok merged commit be903fa into pytorch:master Jun 15, 2021
@mthrok
Copy link
Contributor

mthrok commented Jun 15, 2021

Merging this to see if it works no release/tag.

mthrok pushed a commit that referenced this pull request Jun 15, 2021
@mthrok mthrok changed the title fix tag build so it triggers prerequisites [Cherry-picked 0.9] fix tag build so it triggers prerequisites Jun 15, 2021
@mthrok
Copy link
Contributor

mthrok commented Jun 15, 2021

Sorry I was looking at regular jobs on release/0.9 branch, whereas I should be looking at tag build.

The new workflow

https://app.circleci.com/pipelines/github/pytorch/audio/6328/workflows/5b1b516e-97cf-461e-9db9-388da101b21f

However I just realized that build_doc was running before as well.

https://app.circleci.com/pipelines/github/pytorch/audio/6320/workflows/1aed74f6-1361-4b01-9b4e-4b9536e16510

@mattip Isn't it upload_doc job that has to be triggered on tag?

@mthrok
Copy link
Contributor

mthrok commented Jun 15, 2021

Okay, I cherry-picked the commit and added 0.9.0-rc6 tag, but there is no build_doc job.
https://app.circleci.com/pipelines/github/pytorch/audio/6329/workflows/13669cd5-3c29-402f-ac91-eeeb44a237e2

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

Hmm. Not sure what is going on. There should be a specific tag build, this looks like a nightly build.

@mthrok
Copy link
Contributor

mthrok commented Jun 15, 2021

tag build triggers nightly build (and only nightly build) because only nightly build has upload process

@mattip
Copy link
Contributor Author

mattip commented Jun 15, 2021

Right, the tag symbol shows at the top. It should have triggered the binary_linux_wheel_py3.8_cpu (no nightly prefix) due to the filter. Maybe merging the changed filter together with the tag got circleCI confused?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants