-
Notifications
You must be signed in to change notification settings - Fork 739
[Cherry-picked 0.9] fix tag build so it triggers prerequisites #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am pretty sure this needs to be cherry-picked to the 0.9 release branch |
| only: | ||
| - /.*/ | ||
| tags: | ||
| only: /v[0-9]+(\.[0-9]+)*-rc[0-9]+/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regex looks like it will only match RC. Is this intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Merging this to see if it works no release/tag. |
|
Sorry I was looking at regular jobs on
|
|
Okay, I cherry-picked the commit and added |
|
Hmm. Not sure what is going on. There should be a specific tag build, this looks like a nightly build. |
|
tag build triggers nightly build (and only nightly build) because only nightly build has upload process |
|
Right, the tag symbol shows at the top. It should have triggered the |
Port pytorch/vision#3998 and pytorch/vision#4053 so that adding a tag will trigger a documentation build-and-upload. The problem was that the upload depends on both the wheel and the build_docs builds, but those did not have the correct filter so they were not running.
Similar to pytorch/text#1332
It would be nice to see this merged before the next tag event, to make sure the docs are now building (the last few tags did not generate docs), although #1568 already generated the 0.9 docs.