Skip to content

Conversation

@carolineechen
Copy link
Contributor

No description provided.

@@ -1,4 +0,0 @@
# Sphinx build info version 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this file have been deleted (as is the case from following README) or just updated?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's okay either way, as long as the resulting page is rendered correctly. We can come back to this if it affects GitHub's page deployment.

@@ -1,7 +1,7 @@
pre { line-height: 125%; }
td.linenos pre { color: #000000; background-color: #f0f0f0; padding-left: 5px; padding-right: 5px; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with this file -- is this okay or should it be changed back

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you enable your gh-pages build and skim through the doc to see if there is any obvious layout change? If not we can keep the change.

@mthrok
Copy link
Contributor

mthrok commented Jun 10, 2021

Did you install the dependencies as directed in doc build process? i.e. pip install -r requirements.txt in doc directory. If you did that, then things should be fine. The differences on CSS and such might be coming from the upstream repo.

Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token approval

@carolineechen carolineechen merged commit 5b09710 into pytorch:gh-pages Jun 11, 2021
@carolineechen carolineechen deleted the gh-pages branch June 11, 2021 14:25
mthrok pushed a commit to mthrok/audio that referenced this pull request Dec 13, 2022
* update profiler tutorial with new features introduced

* update bigger to higher

* change wording and add some links

Co-authored-by: Brian Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants