Documentation is not being built for tags

[mattip]

🐛 Bug

The circleci build workflow for tags should be building and pushing a version of the documentation, but is not. Compare this nightly build which has build_docs and upload_docs steps, to this tag build which only has binary_win* builds.

I think the problem is in the regereate.py script where it only adds a master filter for windows, which triggers a tag filter as well:

vision/.circleci/regenerate.py

Lines 40 to 50 in 0013d93

	if cu_version.startswith('rocm') and btype == "conda":
	continue
	for unicode in [False]:
	fb = filter_branch
	if windows_latest_only and os_type == "win" and filter_branch is None and \
	(python_version != python_versions[-1] or
	(cu_version not in [cu_versions[0], cu_versions[-1]])):
	fb = "master"
	w += workflow_pair(
	btype, os_type, python_version, cu_version,
	unicode, prefix, upload, filter_branch=fb)

So the only builds that get the tag filter are the windows ones.

This is the same script for text and audio as well, so whatever fix is done here should be done for them as well.

[mthrok]

Hi @mattip

Thanks for raising this. BTW, after the fix, do we still need to manually update the version selector?

[mattip]

do we still need to manually update the version selector?

Yes.

[mattip]

Docs are now being built. There are still some quirks: see #4754