This repository was archived by the owner on Sep 10, 2025. It is now read-only.
Resolve and remove TODO comments #1912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nayef211 Great, I'm quite new to this. Can I now say myself to be a contributor ⭐ ? |
joecummings
approved these changes
Sep 27, 2022
Member
joecummings
left a comment
joecummings
left a comment
There was a problem hiding this comment.
LGTM and that's a nice green checkmark :)
Member
|
Closes #1904 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
splitfunc on JIT mode pytorch#38207 is now closedThanks @arnavmehta7 for creating the initial PR for this (#1904). I'm going to land the changes via this PR instead as the other PR wasn't correctly rebased against the
mainbranch.Closes #1904