Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Commit 766cf9d

Browse files
authored
Resolve and remove TODO comments (#1912)
* Resolve and reemove TODOs * remove todo
1 parent 9b06d56 commit 766cf9d

File tree

2 files changed

+3
-8
lines changed

2 files changed

+3
-8
lines changed

test/torchtext_unittest/prototype/test_functional.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
import os
2-
import platform
3-
import unittest
42

53
import torch
64
import torchtext.data as data
@@ -10,8 +8,6 @@
108

119

1210
class TestFunctional(TorchtextTestCase):
13-
# TODO(Nayef211): remove decorator once https://github.com/pytorch/pytorch/issues/38207 is closed
14-
@unittest.skipIf(platform.system() == "Windows", "Test is known to fail on Windows.")
1511
def test_BasicEnglishNormalize(self) -> None:
1612
test_sample = "'\".<br />,()!?;: Basic English Normalization for a Line of Text '\".<br />,()!?;:"
1713
ref_results = [

torchtext/datasets/multi30k.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,10 @@
1212
from torchdata.datapipes.iter import FileOpener, IterableWrapper
1313
from torchtext._download_hooks import HttpReader
1414

15-
# TODO: Update URL to original once the server is back up (see https://github.com/pytorch/text/issues/1756)
1615
URL = {
17-
"train": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/training.tar.gz",
18-
"valid": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/validation.tar.gz",
19-
"test": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/mmt16_task1_test.tar.gz",
16+
"train": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/training.tar.gz",
17+
"valid": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/validation.tar.gz",
18+
"test": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/mmt16_task1_test.tar.gz",
2019
}
2120

2221
MD5 = {

0 commit comments

Comments
 (0)