todo-decorator-remove-solved #1904
Conversation
|
@arnavmehta7 thanks for creating this! Can you please fix the linter issues that show up on CI before we merge the PR? |
…ask (pytorch#1896) (pytorch#1906) Summary: Pull Request resolved: pytorch#1896 Turn off mask checking for torchtext which is known to have a legal mask Reviewed By: zrphercule Differential Revision: D39445703 fbshipit-source-id: 3f0cacfd39ea11a16c7a06f339872554333b5e97 Co-authored-by: Michael Gschwind <[email protected]>
* Delete experimental_datasets_raw.rst - Deleting outdated docs on experimental datasets * Update sphinx theme to latest
* Delete checkpoints after integration test * Use pytest fixtures to autodelete model assets in integration tests * Created new unittest directory and new workflow for integration tests * Fix imports * Readded ignored assets * Remove changes from download_hooks * change to install instead of develop * Using setup.py develop on unittest and integration tests * set cxx abi flag to 1 * remove symbol prints * set cxx_abi flag * Add expecttest dep * Finalize integration test workflow * Remove cd to root dir * Add helper function to pass correct D_GLIBCXX_USE_CXX11_ABI value from pytorch * Added cxx_abi flag to cmake_cxx_flags * Resolving PR comments * Fix call to compiled_with_cxx11_abi fn * Added new cache variable to store D_GLIBCXX_USE_CXX11_ABI flag value
|
@Nayef211 Thanks, I've tried to do that but I'm still unable to do so. I'm quite new to opensource. I'd be grateful if you can tell me how do I correct that. |
|
How can I fix these MacOS build issues? |
This was fixed by #1889 and should be fixed in your PR once you rebase on the latest main branch. |
Would I need to sync again then do these changes again? EDIT: JUST TRYING THAT |
|
Still MacOS errors? Can you point out my mistake, I'm extremely sorry if I have done something wrong EDIT: Still 3 errors :( |
@arnavmehta7 the current failures are not related to your changes and are caused by flaky tests. Thanks again for working on this. I think you might need to merge in the latest changes from the main branch again since it looks like some of the changes from the latest commits are not reflected in your PR. |
|
@Nayef211 Thanks for guidance, I've done that already :D |
|
@Nayef211 Hey, It is working. |
3 participants
Removed the code as the issue is closed.