Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Resolve and remove TODO comments #1912

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Resolve and remove TODO comments #1912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
106941a
Resolve and reemove TODOs
Nayef211 Sep 26, 2022
9e21268
remove todo
Nayef211 Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions test/torchtext_unittest/prototype/test_functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import os
import platform
import unittest

import torch
import torchtext.data as data
Expand All @@ -10,8 +8,6 @@


class TestFunctional(TorchtextTestCase):
# TODO(Nayef211): remove decorator once https://github.com/pytorch/pytorch/issues/38207 is closed
@unittest.skipIf(platform.system() == "Windows", "Test is known to fail on Windows.")
def test_BasicEnglishNormalize(self) -> None:
test_sample = "'\".<br />,()!?;: Basic English Normalization for a Line of Text '\".<br />,()!?;:"
ref_results = [
Expand Down
7 changes: 3 additions & 4 deletions torchtext/datasets/multi30k.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@
from torchdata.datapipes.iter import FileOpener, IterableWrapper
from torchtext._download_hooks import HttpReader

# TODO: Update URL to original once the server is back up (see https://github.com/pytorch/text/issues/1756)
URL = {
"train": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/training.tar.gz",
"valid": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/validation.tar.gz",
"test": r"https://raw.githubusercontent.com/neychev/small_DL_repo/master/datasets/Multi30k/mmt16_task1_test.tar.gz",
"train": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/training.tar.gz",
"valid": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/validation.tar.gz",
"test": "http://www.quest.dcs.shef.ac.uk/wmt16_files_mmt/mmt16_task1_test.tar.gz",
}

MD5 = {
Expand Down