Skip to content

Separate typechecking and building type declarations #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2021
Merged

Separate typechecking and building type declarations #1588

merged 4 commits into from
Nov 17, 2021

Conversation

@jfuchs
Copy link
Contributor

@jfuchs jfuchs commented Nov 9, 2021

I believe because in a previous PR I've excluded stories from our built type definitions, we aren't typechecking stories. This PR separates typechecking everything from building type definitions for only the exported parts of primer.

I'm open to other ways to accomplish the same thing!

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: d988706

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jfuchs jfuchs added the skip changeset This change does not need a changelog label Nov 9, 2021
@jfuchs jfuchs requested review from a team and colebemis November 9, 2021 22:15
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2021 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 54.96 KB (0%)
dist/browser.umd.js 55.35 KB (0%)

colebemis
colebemis approved these changes Nov 10, 2021
View reviewed changes
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@jfuchs jfuchs marked this pull request as ready for review November 17, 2021 00:55
@jfuchs jfuchs mentioned this pull request Nov 17, 2021
Merged
6 tasks
@jfuchs jfuchs merged commit 25cec73 into main Nov 17, 2021
@jfuchs jfuchs deleted the jfuchs/typecheck-script branch November 17, 2021 17:18
@jfuchs jfuchs mentioned this pull request Nov 17, 2021
Closed
6 tasks
colebemis added a commit that referenced this pull request Nov 23, 2021
@colebemis
Revert "Separate typechecking and building type declarations (#1588)"
0d97025 
This reverts commit 25cec73.
@colebemis colebemis mentioned this pull request Nov 23, 2021
Merged
colebemis added a commit that referenced this pull request Nov 23, 2021
@colebemis
Revert "Separate typechecking and building type declarations" (#1652)
47550d3 
* Revert "Separate typechecking and building type declarations (#1588)"

This reverts commit 25cec73.

* Create mean-shoes-rule.md
pksjce pushed a commit that referenced this pull request Dec 20, 2021
@colebemis @pksjce
Revert "Separate typechecking and building type declarations" (#1652)
5a1fbd7 
* Revert "Separate typechecking and building type declarations (#1588)"

This reverts commit 25cec73.

* Create mean-shoes-rule.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@colebemis colebemis colebemis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfuchs @colebemis