Skip to content

Revert "Separate typechecking and building type declarations" #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2021
Merged

Revert "Separate typechecking and building type declarations" #1652

merged 2 commits into from
Nov 23, 2021

Conversation

@colebemis
Copy link
Contributor

@colebemis colebemis commented Nov 23, 2021 •
edited
Loading

Reverts #1588 which was causing theme-preval.js to not actually be preval'd. Reverting this PR fixes the Error: Cannot find module 'lodash.isempty' error when upgrading to Primer React >v31.2.0.

Fixes #1635

@changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 3ad2791

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2021 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 57.1 KB (0%)
dist/browser.umd.js 57.49 KB (0%)

@colebemis colebemis marked this pull request as ready for review November 23, 2021 22:50
@colebemis colebemis requested review from a team and pksjce November 23, 2021 22:50
jfuchs
jfuchs approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@jfuchs jfuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😥

@colebemis colebemis merged commit 47550d3 into main Nov 23, 2021
@colebemis colebemis deleted the revert-1588-jfuchs/typecheck-script branch November 23, 2021 23:03
@primer-css primer-css mentioned this pull request Nov 23, 2021
Merged
pksjce pushed a commit that referenced this pull request Dec 20, 2021
@colebemis @pksjce
Revert "Separate typechecking and building type declarations" (#1652)
5a1fbd7 
* Revert "Separate typechecking and building type declarations (#1588)"

This reverts commit 25cec73.

* Create mean-shoes-rule.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfuchs jfuchs jfuchs approved these changes

@pksjce pksjce Awaiting requested review from pksjce

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'lodash.isempty'

3 participants

@colebemis @jfuchs