Skip to content

Fix TypeScript errors in the next_major branch #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 28 commits into from
Closed

Fix TypeScript errors in the next_major branch #1620

wants to merge 28 commits into from

Conversation

@jfuchs
Copy link
Contributor

@jfuchs jfuchs commented Nov 17, 2021

This PR addresses the typescript errors in the next_major branch. The offending PRs (my own) got past CI because we previously weren't type checking our stories. They are now typed as of #1588.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

jfuchs added 28 commits November 17, 2021 10:52
@jfuchs
Set up a next_major branch
d18a6b9
@jfuchs
Breadcrumbs no longer accepts styled system props (#1469)
66ea181
@jfuchs
CircleBadge no longer accepts styled system props (#1555)
79ae9f5
@jfuchs
FilteredSearch no longer accepts styled system props (#1559)
e4cc21f
@jfuchs
FilterList no longer accepts styled system props (#1560)
5c59ae7
@jfuchs
FormGroup no longer accepts styled system props (#1562)
759c605
@jfuchs
LabelGroup no longer accepts styled system props (#1565)
35ec527
@jfuchs
Pagination no longer accepts styled system props (#1569)
388e34d
@jfuchs
Popover no longer accepts styled system props (#1570)
dcb6641
@jfuchs
SideNav no longer accepts styled system props (#1572)
01a4e3d
@jfuchs
TabNav no longer accepts styled system props (#1575)
b1e9d00
@jfuchs
Timeline no longer accepts styled system props (#1576)
31100b5
@jfuchs
Truncate no longer accepts styled system props (#1578)
6db06e5
@jfuchs
StateLabel no longer accepts styled system props (#1573)
057118e
@jfuchs
Buttons no longer accept styled system props (#1475)
1a43da6
@jfuchs
CounterLabel no longer accepts styled system props (#1557)
171795a
@jfuchs
Dropdown no longer accepts styled system props (#1558)
faccd29
@jfuchs
Flash no longer accepts styled system props (#1561)
0000d9f
@jfuchs
Header no longer accepts styled system props (#1563)
67b5ecc
@jfuchs
Label no longer accepts styled system props (#1564)
ac9e225
@jfuchs
Link no longer accepts styled system props (#1566)
da81788
@jfuchs
Overlay no longer accepts styled system props (#1567)
cc1480d
@jfuchs
Pagehead no longer accepts styled system props (#1568)
6870530
@jfuchs
SelectMenu no longer accepts styled system props (#1571)
24a796c
@jfuchs
SubNav no longer accepts styled system props (#1574)
402d172
@jfuchs
Tooltip no longer accepts styled system props (#1577)
0c5538d
@jfuchs
UnderlineNav no longer accepts styled system props (#1579)
f9be10f
@jfuchs
Fixes some TypeScript errors in the next_major branch
507529c
@jfuchs jfuchs added the skip changeset This change does not need a changelog label Nov 17, 2021
@jfuchs jfuchs requested a review from colebemis November 17, 2021 20:09
@jfuchs jfuchs requested a review from a team November 17, 2021 20:09
@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2021

⚠️ No Changeset found

Latest commit: 507529c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jfuchs jfuchs changed the title Fixes some TypeScript errors in the next_major branch Fix TypeScript errors in the next_major branch Nov 17, 2021
Base automatically changed from next_major to main November 22, 2021 21:58
@jfuchs jfuchs closed this Nov 30, 2021
@joshblack joshblack deleted the jfuchs/next-major-ts-fixes branch January 19, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colebemis colebemis Awaiting requested review from colebemis

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jfuchs