Fix a few typescript issues in ActionList2 stories #1618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jfuchs
changed the title
siddharthkp
approved these changes
Nov 17, 2021
Member
siddharthkp
left a comment
siddharthkp
left a comment
There was a problem hiding this comment.
Thanks for taking care of these!
Contributor
size-limit report 📦
|
jfuchs
force-pushed
the
jfuchs/actionlist2-stories-type-issues
branch
from
4eb5634 to
0476879
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this after it blocked me merging #1588 (Sorry, had I not sat on that approved PR for so long this wouldn't have happened).
The
anys aren't ideal, but I'm comfortable with them in a stories file.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.