MCO-1064: Promote MachineConfigNode feature gate to default

[isabella-janssen]

This promotes the MachineConfigNode feature gate to Default.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Note: This PR builds on #2273, which should be merged first. After it's merge, this PR can be rebased.

This promotes the MachineConfigNode feature gate from TechPreviewNoUpgrade to Default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Note: This PR builds on #2273, which should be merged first. After it's merge, this PR can be rebased.

This promotes the MachineConfigNode feature gate from TechPreviewNoUpgrade to Default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[isabella-janssen]

/hold

This depends on some other steps being completed first. More info can be found here.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This promotes the MachineConfigNode feature gate from TechPreviewNoUpgrade to Default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1064 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This promotes the MachineConfigNode feature gate to Default.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[deads2k]

/payload help

[openshift-ci]

@deads2k: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

[isabella-janssen]

/retest-required

[sdodson]

/test verify-feature-promotion

[isabella-janssen]

/test e2e-aws-serial-techpreview-1of2

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/retest-required

[isabella-janssen]

/retest-required

[isabella-janssen]

/retest-required

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[JoelSpeed]

There are three tests, which have been renamed, where the aggregate of the renames puts their pass rate at 94%. Every other test is over the 95% threshold.

In the case of the three failed tests, the failures were over a week ago, and if we exclude the pre-rename results, are at 100% over 19 runs in the past week.

Given we would normally not look at the second week if we have enough data from the first week, I think on this occasion we should discount the older results.

/lgtm
/override ci/prow/verify-feature-promotion

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

In response to this:

There are three tests, which have been renamed, where the aggregate of the renames puts their pass rate at 94%. Every other test is over the 95% threshold.

In the case of the three failed tests, the failures were over a week ago, and if we exclude the pre-rename results, are at 100% over 19 runs in the past week.

Given we would normally not look at the second week if we have enough data from the first week, I think on this occasion we should discount the older results.

/lgtm
/override ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[isabella-janssen]

/unhold

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cb94c55 and 2 for PR HEAD c3a69de in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1c8afbd and 1 for PR HEAD c3a69de in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1c8afbd and 2 for PR HEAD c3a69de in total

[openshift-ci]

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial	9ac70f2	link	true	/test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

/override ci/prow/verify-feature-promotion

Per previous #2288 (comment)

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

In response to this:

/override ci/prow/verify-feature-promotion

Per previous #2288 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202506190942.p0.gef565c2.assembly.stream.el9.
All builds following this will include this PR.

[isabella-janssen]

/cherrypick release-4.19

[openshift-cherrypick-robot]

@isabella-janssen: #2288 failed to apply on top of branch "release-4.19":

Applying: promote MachineConfigNode feature gate to default
Using index info to reconstruct a base tree...
M	features.md
M	features/features.go
M	payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
M	payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
Falling back to patching base and 3-way merge...
Auto-merging payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
CONFLICT (content): Merge conflict in payload-manifests/featuregates/featureGate-SelfManagedHA-Default.yaml
Auto-merging payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
CONFLICT (content): Merge conflict in payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
Removing payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-TechPreviewNoUpgrade.crd.yaml
Removing payload-manifests/crds/0000_80_machine-config_01_machineconfignodes-DevPreviewNoUpgrade.crd.yaml
Removing machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-TechPreviewNoUpgrade.crd.yaml
Removing machineconfiguration/v1alpha1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-DevPreviewNoUpgrade.crd.yaml
Removing machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-TechPreviewNoUpgrade.crd.yaml
Removing machineconfiguration/v1/zz_generated.crd-manifests/0000_80_machine-config_01_machineconfignodes-DevPreviewNoUpgrade.crd.yaml
Auto-merging features/features.go
Auto-merging features.md
CONFLICT (content): Merge conflict in features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 promote MachineConfigNode feature gate to default

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.