MCO-1519: Deploy v1 CRDs for the MCN API #2273

isabella-janssen · 2025-04-11T17:43:01Z

Merge Plan

This should merge simultaneously with MCO-1519: Adapt MCO code to use V1 MCN API machine-config-operator#4992 & MCO-1519: Adapt MCN tests to use V1 API origin#29701.

This updates the CRD list to deploy V1 CRDs for MCN instead of v1alpha1 CRDs.

openshift-ci-robot · 2025-04-11T17:43:05Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Note: PR builds on #2255, which should be merged first. After it's merge, this PR can be rebased.

Included work:

Update CRD list to deploy V1 CRDs for MCN instead of v1alpha1 CRDs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-04-11T17:43:06Z

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci · 2025-04-11T17:43:07Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-04-17T19:49:43Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Note: PR builds on #2255, which should be merged first. After it's merge, this PR can be rebased.

Update CRD list to deploy V1 CRDs for MCN instead of v1alpha1 CRDs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-04-17T19:59:19Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Note: PR builds on #2255, which should be merged first. After it's merge, this PR can be rebased.

This updates the CRD list to deploy V1 CRDs for MCN instead of v1alpha1 CRDs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2025-04-17T19:59:37Z

/hold

This depends on #2255 being merged first.

openshift-ci-robot · 2025-04-18T18:54:05Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Note: PR builds on #2255, which should be merged first. After it's merge, this PR can be rebased.

Note that this should merge simultaneously with #2273.

This updates the CRD list to deploy V1 CRDs for MCN instead of v1alpha1 CRDs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-04-18T18:56:29Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Note that this should merge simultaneously with #2273.

This updates the CRD list to deploy V1 CRDs for MCN instead of v1alpha1 CRDs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2025-04-21T23:00:53Z

/retest-required

openshift-ci · 2025-04-22T13:01:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isabella-janssen
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2025-04-22T17:47:21Z

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`2ec3add`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-aws-ovn-techpreview	`2ec3add`	link	true	`/test e2e-aws-ovn-techpreview`
ci/prow/e2e-aws-ovn-hypershift-conformance	`2ec3add`	link	true	`/test e2e-aws-ovn-hypershift-conformance`
ci/prow/e2e-aws-serial-techpreview	`2ec3add`	link	true	`/test e2e-aws-serial-techpreview`
ci/prow/e2e-gcp	`2ec3add`	link	false	`/test e2e-gcp`
ci/prow/e2e-azure	`2ec3add`	link	false	`/test e2e-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci · 2025-04-22T21:01:42Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fac1e850-1fbc-11f0-862d-e84003de272e-0

openshift-ci · 2025-04-23T00:37:51Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2cdb3df0-1fdb-11f0-8ce0-4789540d94c0-0

openshift-ci · 2025-04-23T00:38:42Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4b3356c0-1fdb-11f0-9b35-226304d0edb2-0

openshift-ci · 2025-04-23T00:39:03Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5783a6f0-1fdb-11f0-90db-891d487db3b1-0

openshift-ci · 2025-04-23T00:44:13Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/10678010-1fdc-11f0-8580-ddd5fb8ff9ed-0

openshift-ci · 2025-04-23T00:45:13Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-serial-ipv4

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/320af350-1fdc-11f0-8aee-f8ae028cc17c-0

openshift-ci · 2025-04-23T00:46:17Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T00:47:08Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T00:47:52Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-dualstack

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/915b95d0-1fdc-11f0-9fe0-b77ca0a6c4db-0

openshift-ci · 2025-04-23T11:51:47Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/518ee7b0-2039-11f0-9293-096f11f7234d-0

openshift-ci · 2025-04-23T11:52:16Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6426bb50-2039-11f0-8ebb-448e5b2e76d2-0

openshift-ci · 2025-04-23T11:53:33Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f56b920-2039-11f0-8c1b-32964ce9e1e2-0

openshift-ci · 2025-04-23T11:54:19Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f8c1d70-2039-11f0-9397-897d6e7a216b-0

openshift-ci · 2025-04-23T11:55:26Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d55d1f80-2039-11f0-8579-2e6b98bca7b9-0

openshift-ci · 2025-04-23T11:58:03Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T11:58:33Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T11:58:53Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

isabella-janssen · 2025-04-23T17:09:38Z

/close

Closing in favor of deploying the V1 CRDs in the PR creating the V1 API (#2255).

openshift-ci · 2025-04-23T17:10:56Z

@isabella-janssen: Closed this PR.

In response to this:

/close

Closing in favor of deploying the V1 CRDs in the PR creating the V1 API (#2255).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-04-23T18:31:49Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3424ddf0-2071-11f0-8bbf-22c14e462e13-0

openshift-ci · 2025-04-23T18:32:18Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/469af8c0-2071-11f0-8d94-3330afaf17c2-0

openshift-ci · 2025-04-23T18:55:03Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6e400570-2074-11f0-8e92-9a7db8955ad6-0

openshift-ci · 2025-04-23T19:00:48Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/41945cf0-2075-11f0-8b8f-d3f3e03d2081-0

openshift-ci · 2025-04-23T19:01:15Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50119f40-2075-11f0-929c-af1a76b690ed-0

openshift-ci · 2025-04-23T19:03:19Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9a6e0790-2075-11f0-9dd2-99779bc6df7a-0

openshift-ci · 2025-04-23T19:04:40Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bb987a40-2075-11f0-801a-b56670c0afcc-0

openshift-ci · 2025-04-23T19:34:51Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-24T00:01:29Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/42c4fba0-209f-11f0-9197-d658c69655f2-0

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025

openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 11, 2025

isabella-janssen force-pushed the mco-1519-deployMCNv1CRDs branch 5 times, most recently from c4a2986 to dc12cdb Compare April 11, 2025 19:35

isabella-janssen marked this pull request as ready for review April 11, 2025 19:36

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025

isabella-janssen mentioned this pull request Apr 11, 2025

MCO-1518: Create V1 MachineConfigNodes API & deploy V1 MCN CRDs #2255

Merged

openshift-ci bot requested review from cgwalters and deads2k April 11, 2025 19:37

isabella-janssen mentioned this pull request Apr 17, 2025

MCO-1064: Promote MachineConfigNode feature gate to default #2288

Merged

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2025

isabella-janssen mentioned this pull request Apr 18, 2025

MCO-1519: Adapt MCO code to use V1 MCN API openshift/machine-config-operator#4992

Merged

isabella-janssen added 2 commits April 22, 2025 09:38

add v1 api for MachineConfigNode

ae8ec66

update 'update-payload-crds.sh' to deploy v1 crds for MCN api

2ec3add

isabella-janssen force-pushed the mco-1519-deployMCNv1CRDs branch from cb6f405 to 2ec3add Compare April 22, 2025 13:54

openshift-ci bot closed this Apr 23, 2025

isabella-janssen deleted the mco-1519-deployMCNv1CRDs branch May 15, 2025 02:53

MCO-1519: Deploy v1 CRDs for the MCN API #2273

MCO-1519: Deploy v1 CRDs for the MCN API #2273

Uh oh!

Conversation

isabella-janssen commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 11, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 11, 2025

Uh oh!

openshift-ci bot commented Apr 11, 2025

Uh oh!

openshift-ci-robot commented Apr 17, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 17, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isabella-janssen commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isabella-janssen commented Apr 21, 2025

Uh oh!

openshift-ci bot commented Apr 22, 2025

Uh oh!

openshift-ci bot commented Apr 22, 2025

Uh oh!

openshift-ci bot commented Apr 22, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

isabella-janssen commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

isabella-janssen commented Apr 11, 2025 •

edited

Loading

openshift-ci-robot commented Apr 11, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 17, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 17, 2025 •

edited by openshift-ci bot

Loading

isabella-janssen commented Apr 17, 2025 •

edited

Loading

openshift-ci-robot commented Apr 18, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 18, 2025 •

edited by openshift-ci bot

Loading