MCO-1519: Adapt MCO code to use V1 MCN API #4992

isabella-janssen · 2025-04-18T18:08:20Z

Merge Plan

This should merge simultaneously with
- MCO-1518: Create V1 MachineConfigNodes API & deploy V1 MCN CRDs api#2255
- MCO-1519: Adapt MCN tests to use V1 API origin#29701.

- What I did
This updates references to MachineConfigNode's v1alpha1 API to instead reference the v1 API created in openshift/api#2255.

- How to verify it

Validate MCN functionality in a live cluster using the following Clusterbot launch command:
launch 4.19,openshift/api#2273,openshift/machine-config-operator#4992 gcp,techpreview
Origin tests should run. See payload tests run on MCO-1519: Adapt MCN tests to use V1 API origin#29701.

- Description for the changelog
MCO-1519: update MCN API references from v1alpha1 to v1

openshift-ci · 2025-04-18T18:08:24Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2025-04-18T18:57:00Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Note that this should merge simultaneously with openshift/api#2273.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2025-04-18T18:57:40Z

/hold

This should merge with openshift/api#2255 & openshift/origin#29701.

openshift-ci-robot · 2025-04-22T18:46:33Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Merge Plan

This should merge simultaneously with MCO-1519: Deploy v1 CRDs for the MCN API api#2273 & MCO-1519: Adapt MCN tests to use V1 API origin#29701.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-04-22T19:00:10Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Merge Plan

This should merge after MCO-1518: API & client-go bumps for MCN V1 API #4991.

This should merge simultaneously with MCO-1519: Deploy v1 CRDs for the MCN API api#2273 & MCO-1519: Adapt MCN tests to use V1 API origin#29701.

- What I did
This updates references to MachineConfigNode's v1alpha1 API to instead reference the v1 API created in openshift/api#2255.

- How to verify it

- Description for the changelog
MCO-1519: update MCN API references from v1alpha1 to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-04-22T19:00:16Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Merge Plan

This should merge after MCO-1518: API & client-go bumps for MCN V1 API #4991.

This should merge simultaneously with MCO-1519: Deploy v1 CRDs for the MCN API api#2273 & MCO-1519: Adapt MCN tests to use V1 API origin#29701.

- What I did
This updates references to MachineConfigNode's v1alpha1 API to instead reference the v1 API created in openshift/api#2255.

- How to verify it

- Description for the changelog
MCO-1519: update MCN API references from v1alpha1 to v1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-04-22T21:01:42Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fac1e850-1fbc-11f0-862d-e84003de272e-0

openshift-ci · 2025-04-23T00:37:51Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2cdb3df0-1fdb-11f0-8ce0-4789540d94c0-0

openshift-ci · 2025-04-23T00:38:43Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4b3356c0-1fdb-11f0-9b35-226304d0edb2-0

openshift-ci · 2025-04-23T00:39:04Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5783a6f0-1fdb-11f0-90db-891d487db3b1-0

openshift-ci · 2025-04-23T00:44:14Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/10678010-1fdc-11f0-8580-ddd5fb8ff9ed-0

openshift-ci · 2025-04-23T00:45:14Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-serial-ipv4

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/320af350-1fdc-11f0-8aee-f8ae028cc17c-0

openshift-ci · 2025-04-23T00:46:19Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T00:47:10Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T00:47:49Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-dualstack

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/915b95d0-1fdc-11f0-9fe0-b77ca0a6c4db-0

openshift-ci · 2025-04-23T11:51:48Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/518ee7b0-2039-11f0-9293-096f11f7234d-0

openshift-ci · 2025-04-23T11:52:17Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6426bb50-2039-11f0-8ebb-448e5b2e76d2-0

openshift-ci · 2025-04-25T00:53:20Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ac1a8130-216f-11f0-943d-ea71cc75e5b9-0

openshift-ci · 2025-04-25T00:53:37Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b606f0c0-216f-11f0-89e1-973f03e2f996-0

openshift-ci · 2025-04-25T00:53:58Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c2f5cae0-216f-11f0-9adc-500ee8a9bc3e-0

openshift-ci · 2025-04-25T00:54:18Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ce3d3690-216f-11f0-894e-52e56690aa2e-0

openshift-ci · 2025-04-25T02:59:58Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5daad560-2181-11f0-9718-7ef79a6d7a66-0

openshift-ci · 2025-04-25T03:01:38Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/98c39e20-2181-11f0-8c2c-6350eb2dc051-0

openshift-ci · 2025-04-25T03:02:01Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a68aafd0-2181-11f0-8276-d141e81fbe7b-0

openshift-ci · 2025-04-25T03:02:20Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b1d0e300-2181-11f0-98ff-cba62ef0da8f-0

openshift-ci · 2025-04-25T03:02:38Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bcc88100-2181-11f0-83c3-2dc68460cdea-0

openshift-ci · 2025-04-25T03:02:59Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-single-node-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c98db310-2181-11f0-8faa-d9d3eeac90ec-0

openshift-ci · 2025-04-25T03:03:21Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-single-node-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d5fa64e0-2181-11f0-969e-97740849b627-0

openshift-ci · 2025-04-25T03:03:43Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-dualstack-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e31753e0-2181-11f0-86d7-8dfac17a661a-0

openshift-ci · 2025-04-25T03:04:02Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-ipv6-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/eec06790-2181-11f0-9ef8-0b77cd7c137b-0

openshift-ci · 2025-04-25T03:04:26Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fd39b240-2181-11f0-8314-55f768b2b20f-0

openshift-ci · 2025-04-25T03:04:47Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/09935140-2182-11f0-941b-5929859dc36d-0

openshift-ci · 2025-04-25T03:05:09Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/16ce76a0-2182-11f0-885d-522ccd87f166-0

sdodson · 2025-04-25T15:45:22Z

/tide refresh

sdodson · 2025-04-25T15:47:29Z

/test verify

openshift-ci · 2025-04-25T15:56:01Z

New changes are detected. LGTM label has been removed.

sdodson · 2025-04-25T16:32:41Z

Merging these PRs simultaneously, the testing was completed as payload jobs on the origin PR
openshift/origin#29701
openshift/api#2255
#4992

openshift-bot · 2025-04-25T21:12:26Z

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202504251855.p0.gc70fd65.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2025

isabella-janssen changed the title ~~(WIP) Use v1 mcn crds~~ MCO-1519: Adapt MCO code to use V1 MCN API Apr 18, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 18, 2025

isabella-janssen marked this pull request as ready for review April 18, 2025 18:57

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2025

openshift-ci bot requested review from LorbusChris and dkhater-redhat April 18, 2025 18:57

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2025

isabella-janssen mentioned this pull request Apr 22, 2025

MCO-1519: Adapt MCN tests to use V1 API openshift/origin#29701

Merged

isabella-janssen force-pushed the use-v1-mcn-crds branch from 4bd14fa to 8bcf975 Compare April 22, 2025 18:42

isabella-janssen mentioned this pull request Apr 22, 2025

MCO-1519: Deploy v1 CRDs for the MCN API openshift/api#2273

Closed

isabella-janssen force-pushed the use-v1-mcn-crds branch from 8bcf975 to bc1eb74 Compare April 23, 2025 11:11

isabella-janssen force-pushed the use-v1-mcn-crds branch from 287f65a to 381bfa6 Compare April 25, 2025 02:58

isabella-janssen mentioned this pull request Apr 25, 2025

MCO-1518: Create V1 MachineConfigNodes API & deploy V1 MCN CRDs openshift/api#2255

Merged

sdodson added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025

(*newMCNode.Status.ConfigVersion) -> newMCNode.Status.ConfigVersion

25795b5

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2025

sdodson added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 25, 2025

sdodson merged commit c70fd65 into openshift:main Apr 25, 2025
5 of 17 checks passed

isabella-janssen deleted the use-v1-mcn-crds branch May 15, 2025 03:08

MCO-1519: Adapt MCO code to use V1 MCN API #4992

MCO-1519: Adapt MCO code to use V1 MCN API #4992

Uh oh!

Conversation

isabella-janssen commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 18, 2025

Uh oh!

openshift-ci-robot commented Apr 18, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isabella-janssen commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 22, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 22, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 22, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 22, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 23, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

openshift-ci bot commented Apr 25, 2025

Uh oh!

sdodson commented Apr 25, 2025

Uh oh!

isabella-janssen commented Apr 18, 2025 •

edited

Loading

openshift-ci-robot commented Apr 18, 2025 •

edited by openshift-ci bot

Loading

isabella-janssen commented Apr 18, 2025 •

edited

Loading

openshift-ci-robot commented Apr 22, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 22, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 22, 2025 •

edited by openshift-ci bot

Loading